Skip to content

canonical: metadata validation #2322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oiatsiuk wants to merge 2 commits into
base: main
Choose a base branch
from
+126 −13
Open

canonical: metadata validation #2322

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c69ea1
canonical: metadata validation
oiatsiuk Apr 6, 2026
d9ce0f4
canonical: metadata validation
oiatsiuk Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions src/canonical/handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,16 +447,10 @@ export async function processScrapedContent(context) {
return null;
}

if (!scrapedObject?.scrapeResult?.canonical) {
log.warn(`[canonical] No canonical metadata in S3 object: ${key}`);
return {
url: finalUrl,
checks: [{
check: CANONICAL_CHECKS.CANONICAL_TAG_MISSING.check,
success: false,
explanation: CANONICAL_CHECKS.CANONICAL_TAG_MISSING.explanation,
}],
};
const canonicalMetadata = scrapedObject?.scrapeResult?.canonical;
if (!canonicalMetadata || typeof canonicalMetadata !== 'object' || Object.keys(canonicalMetadata).length === 0) {
log.warn(`[canonical] No canonical metadata in S3 object: ${key}, skipping page`);
return null;
}

// Filter out scraped pages that redirected to auth/login pages or PDFs
Expand All @@ -477,7 +471,6 @@ export async function processScrapedContent(context) {
}

// Use canonical metadata already extracted by the scraper (Puppeteer)
const canonicalMetadata = scrapedObject.scrapeResult.canonical;
const canonicalUrl = canonicalMetadata.href || null;
const canonicalTagChecks = [];

Expand Down
Loading