feat(audit-url): add moneyPages source to auditTargetURLs config#1496
Open
feat(audit-url): add moneyPages source to auditTargetURLs config#1496
Conversation
…custom-list-of-audit-target-URLs
…custom-list-of-audit-target-URLs
Add moneyPages as a new audit target URL source alongside manual,
with identical structure (array of { url } entries) and full
cross-source deduplication support.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Base automatically changed from
SITES-42547-Manage-a-custom-list-of-audit-target-URLs
to
main
April 3, 2026 17:05
| manual: Joi.array().items(Joi.object({ | ||
| url: Joi.string().uri().required(), | ||
| })).optional().default([]), | ||
| moneyPages: Joi.array().items(Joi.object({ |
Contributor
There was a problem hiding this comment.
@nitinja , Let's make sure we can update individual auditTargetURLs keys separately without affecting each other, for example:
% curl -X PATCH \
-d '{
"config": {
"auditTargetURLs": {
"manual": [
{
"url": "https://example.com/path1"
},
{
"url": "https://example.com/path2"
}
]
}
}
}' \
"https://SPACECAT_API/sites/SITE_ID"
% curl -X PATCH \
-d '{
"config": {
"auditTargetURLs": {
"moneyPages": [
{
"url": "https://example.com/money-page1"
},
{
"url": "https://example.com/money-page2"
}
]
}
}
}' \
"https://SPACECAT_API/sites/SITE_ID"
In the database, we should have both manual and moneyPages.
Contributor
There was a problem hiding this comment.
^^^ That way, the API will be more resilient, and we will have less payload input data. Otherwise, to update any individual key, you would need to include all keys to preserve them.
slitviachenko
requested changes
Apr 6, 2026
Contributor
slitviachenko
left a comment
slitviachenko
left a comment
There was a problem hiding this comment.
@nitinja , I left a comment, please take a look when you have time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add moneyPages as a new audit target URL source alongside manual, with identical structure (array of { url } entries) and full cross-source deduplication support.
Please ensure your pull request adheres to the following guidelines:
Related Issues
Thanks for contributing!