Skip to content

Fix deployment spec annotation#170

Merged
adyanth merged 2 commits intomainfrom
168-fix-pod-restart
Jun 8, 2025
Merged

Fix deployment spec annotation#170
adyanth merged 2 commits intomainfrom
168-fix-pod-restart

Conversation

@adyanth
Copy link
Copy Markdown
Owner

@adyanth adyanth commented Jun 8, 2025

The change in k8s apply exposed a bug where previously the deployment's annotations were being updated that would not have restarted the pods.

Fixes #168

@adyanth adyanth force-pushed the 168-fix-pod-restart branch 2 times, most recently from a70c3e4 to ca48ba4 Compare June 8, 2025 04:13
@adyanth adyanth force-pushed the 168-fix-pod-restart branch from ca48ba4 to f9c266b Compare June 8, 2025 05:13
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 8, 2025

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/adyanth/cloudflare-operator/internal/controller 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/adyanth/cloudflare-operator/internal/controller/generic_tunnel_reconciler.go 0.00% (ø) 160 (+2) 0 160 (+2)
github.com/adyanth/cloudflare-operator/internal/controller/tunnelbinding_controller.go 0.00% (ø) 309 (+3) 0 309 (+3)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@adyanth adyanth merged commit 74efcc9 into main Jun 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tunnel needs to be restarted manually after creating a TunnelBinding

1 participant