Replace FHIR/Ucum-java with ucumate for improved performance#2511
Merged
Conversation
Migrate from FHIR/Ucum-java to ucumate (fhnaumann/ucumate), which provides up to 100× performance improvement for UCUM operations. Key changes: - Replace au.csiro.pathling:ucum dependency with ucumate-core 1.0.8 from Maven Central (io.github.fhnaumann:ucumate-core) - Rewrite Ucum.java wrapper to use ucumate's UCUMService API - Use pattern matching on CanonicalizationResult to handle success/failure - Extract canonical values using magnitude().getValue() - Get canonical codes using service.print(canonicalTerm()) - Add logging for UCUM operation errors - Update test dependencies to use ucumate's UCUMService type The Ucum wrapper class maintains all existing public APIs, ensuring no breaking changes for consumers. Error handling now logs warnings for failed canonicalisations before returning null. Resolves: #2510
johngrimes
added
the
optimisation
Use pull_request instead of pull_request_target to run the workflow in the context of the PR head rather than the base repository, which is more appropriate for standard pull requests.
|
Member
Author
|
Here are the results of the benchmark: 
/cc @fhnaumann @piotrszul |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
au.csiro.pathling:ucumtoio.github.fhnaumann:ucumate-core:1.0.8Ucum.javawrapper using ucumate's APIBreaking changes
None. All public APIs remain unchanged.
Closes #2510