fix: raft snapshot sync#435
Open
kroggen wants to merge 12 commits into
Open
Conversation
hayarobi
reviewed
Apr 16, 2026
| if node == nil { | ||
| return ErrRaftNotReady | ||
| } | ||
| // A MsgHeartbeat from the leader carries the leader's current commit index. |
Member
There was a problem hiding this comment.
I am concerned that this modification might cause other side effects. I think it's better waiting for the synchronization tests on some more cases.
kroggen
changed the title
hayarobi
reviewed
Apr 24, 2026
kroggen
force-pushed
the
fix/raft-snapshot-sync
branch
from
93b0973 to
6f907ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.