Fix typo in light component documentation#5807
Open
thatguyjk wants to merge 1 commit intoaframevr:masterfrom
Open
Fix typo in light component documentation#5807thatguyjk wants to merge 1 commit intoaframevr:masterfrom
thatguyjk wants to merge 1 commit intoaframevr:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Light component documentation to fix a typo/grammar issue in the introductory description.
Changes:
- Improves wording in the note about light performance cost (adds a missing conjunction).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| The light component defines the entity as a source of light. Light affects all | ||
| materials that have not specified a flat shading model with `shader: flat`. | ||
| Note that lights are computationally expensive we should limit number of lights | ||
| Note that lights are computationally expensive and we should limit number of lights |
There was a problem hiding this comment.
Grammar: “limit number of lights” should be “limit the number of lights” (or “limit the number of lights in a scene”) for correct phrasing.
Suggested change
| Note that lights are computationally expensive and we should limit number of lights | |
| Note that lights are computationally expensive and we should limit the number of lights |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Changes proposed: