Skip to content

Add bare minimum Modrinth configuration#210

Open
bloxgate wants to merge 1 commit intoage-series:devfrom
bloxgate:feature/minotaur
Open

Add bare minimum Modrinth configuration#210
bloxgate wants to merge 1 commit intoage-series:devfrom
bloxgate:feature/minotaur

Conversation

@bloxgate
Copy link
Copy Markdown
Member

@bloxgate bloxgate commented Jun 10, 2022

Adds a gradle task that will publish if you have your MODRINTH_TOKEN set. Still manual at the moment

At the moment running this would create a version identical to the current 1.0.1 version, including the changelog.

ToDo:

  • Automate this to publish on some criteria

@bloxgate bloxgate requested a review from jrddunbr June 10, 2022 02:45
Copy link
Copy Markdown
Contributor

@jrddunbr jrddunbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Various thoughts but mostly there.

Comment thread build.gradle
gameVersions = [ "$mcVersion" ]
changelog = file('changes.md').text
dependencies {
required.project("ordsPcFz")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we leave a comment here that it depends on KFF? Then I don't need to look up the ID.

Comment thread gradle.properties
Comment thread build.gradle
modrinth {
token = System.getenv("MODRINTH_TOKEN")
projectId = "iTyN4Kv7"
versionNumber = "$project.version"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment further down about how this is not really globalized.

@jrddunbr
Copy link
Copy Markdown
Contributor

Recent merges mean that this PR needs to be rebased/refactored a bit.

@jrddunbr jrddunbr self-requested a review September 20, 2023 01:42
Copy link
Copy Markdown
Contributor

@jrddunbr jrddunbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be rebased to actually be mergable at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants