perf(harness): skip marketplace restage when skill files are unchanged - #2893
Open
jialiuyang wants to merge 2 commits into
Open
perf(harness): skip marketplace restage when skill files are unchanged#2893jialiuyang wants to merge 2 commits into
jialiuyang wants to merge 2 commits into
Conversation
writeIfChanged hashed the on-disk copy and the incoming bytes separately on every call. Compare length first, then the bytes, so an unchanged skill is not rewritten and a size mismatch does not read the whole file. Fixes agentscope-ai#2881
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
2.0.3-SNAPSHOT (main)
Description
MarketplaceStager.writeIfChangedhashed the on-disk file and the incoming bytes on everystage()call, even when the skill had not changed. Length is compared first; only equal-length files are read, and they are compared withArrays.equalsinstead of two SHA-256 digests. Unchanged files keep their mtime. A size mismatch no longer reads the whole file.MarketplaceStagerWriteIfChangedTestcovers missing files, size mismatch, identical bytes, same-length different bytes, and restage throughstage().Fixes #2881
Checklist
mvn spotless:applymvn -pl agentscope-harness -am -Dtest=MarketplaceStagerWriteIfChangedTest,MarketplaceStagerExecBitTest test)