Fix DB startup crash and explicit shared DB migration#1566
Open
FilipJaskovic wants to merge 3 commits into
Open
Fix DB startup crash and explicit shared DB migration#1566FilipJaskovic wants to merge 3 commits into
FilipJaskovic wants to merge 3 commits into
Conversation
Owner
|
Thanks, since this is a relatively big change I want to implement it myself (I am a little busy right now) but I will definitely use these commits to make sure I have not missed anything, I definitely appreciate your work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes DB startup issues around corrupt rows and shared DB migration.
What changed
shared_database_path(CLI or config) is explicitly set and DB open fails.test.dbexists, bootstrap from legacy DB once so data is migrated.boolfromensure_database_compatibility(...)andsplit_database(...).