Document <D-...> modifier and macOS Ctrl/Cmd behavior in keys.config#1613
Open
moritzketzer wants to merge 1 commit into
Open
Document <D-...> modifier and macOS Ctrl/Cmd behavior in keys.config#1613moritzketzer wants to merge 1 commit into
moritzketzer wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds documentation in the keys configuration file to describe the new <D-k> (Command/Meta key) modifier syntax and clarifies the behavior of Ctrl vs Command modifiers on macOS.
Changes:
- Documents the
<D-k>syntax for the macOS Command/meta modifier. - Adds a note explaining how
<C-k>and<D-k>map to physical keys on macOS.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+15
to
+16
| # Note: on macOS, Qt swaps Ctrl and Cmd by default (see Qt::AA_MacDontSwapCtrlAndMeta), | ||
| # so <C-k> binds to the physical Control key and <D-k> binds to the physical Command (⌘) key. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pdf_viewer/input.cppacceptsC,D,A,Sas modifier tokens,but the syntax-help block at the top of
pdf_viewer/keys.configonlyshows
<C-...>and<A-...>.<D-...>(command/meta) isundiscoverable without reading the parser.
On macOS this matters:
<C-k>binds to physical Control,<D-k>binds to physical Command (⌘) — a Mac user expecting ⌘C fromcopy <C-c>gets physical Ctrl+C instead.Doc-only change to the comment block.