🎨 Palette: Add context-aware ARIA labels to sortable citation action buttons#188
🎨 Palette: Add context-aware ARIA labels to sortable citation action buttons#188aicoder2009 wants to merge 1 commit into
Conversation
…buttons Co-authored-by: aicoder2009 <127642633+aicoder2009@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis change adds guidance for context-aware ChangesAccessible repeating action labels
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What:
Added descriptive
aria-labelattributes to the generic, repetitive action buttons ([copy],[edit],[delete],[share],[+ add notes], etc.) within theSortableCitationcomponent.Why:
When rendering a list of citations, screen reader users previously heard the same generic action (e.g., "edit") repeated for every item in the list, making it ambiguous which specific item the action applied to, or what the action fully entailed.
Before/After:
Before:
<button>[edit]</button>(Announces: "edit, button")After:
<button aria-label="Edit citation">[edit]</button>(Announces: "Edit citation, button")Accessibility:
This specifically improves the WCAG 2.1 guideline 4.1.2 (Name, Role, Value) by ensuring that text links and icon buttons provide sufficient contextual information to assistive technologies, avoiding ambiguity in repeated list structures. The
[copy]and[copy-in-text]labels also dynamically update to confirm success to screen readers.PR created automatically by Jules for task 11197480258152816486 started by @aicoder2009
Summary by CodeRabbit