Skip to content

⚡ Bolt: Optimize project lists fetching by deriving in-memory #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aicoder2009 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Bolt: Optimize project lists fetching by deriving in-memory #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,7 @@
## 2024-05-18 - Concurrent Fetching with Owner IDs in Share Links
**Learning:** In the share system, endpoints processing a share code typically suffer from waterfall latency by first loading target entity details (like a project) and then querying its associated elements (like project lists) using the entity's owner ID (`userId`). However, the `shareLink` object already contains the `userId` field (representing the owner's ID).
**Action:** Always leverage the existing owner's ID within `shareLink` to bypass sequential dependencies and fetch parent entities (like projects) concurrently with their child elements (like user lists) using `Promise.all`.

## 2025-02-12 - Derive Subsets In-Memory
**Learning:** The DynamoDB implementation lacks a Global Secondary Index (GSI) for `projectId` on lists, so backend endpoints (like `/api/projects/[id]/lists`) fetch all of a user's lists and filter them in memory anyway.
**Action:** When a global collection (like all lists) and a subset of that collection (like project lists) are needed simultaneously on the frontend, fetch the global collection and derive the subset in-memory using array filtering. This prevents redundant backend database queries and eliminates an unnecessary API request, improving page load performance.
17 changes: 7 additions & 10 deletions src/app/projects/[id]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,17 +58,15 @@ export default function ProjectDetailPage({ params }: { params: Promise<{ id: st
setIsLoading(true);

// OPTIMIZATION: Execute independent network requests and JSON parsing concurrently
// using Promise.all. This prevents a 3-step waterfall, reducing Time to First Byte
// (TTFB) and overall load time significantly on this detail page.
const [projectRes, listsRes, allListsRes] = await Promise.all([
// using Promise.all. This prevents a waterfall, reducing Time to First Byte (TTFB).
// We fetch all lists and derive the project's lists in-memory to avoid a redundant API call.
const [projectRes, allListsRes] = await Promise.all([
fetch(`/api/projects/${projectId}`),
fetch(`/api/projects/${projectId}/lists`),
fetch("/api/lists"),
]);

const [projectResult, listsResult, allListsResult] = await Promise.all([
const [projectResult, allListsResult] = await Promise.all([
projectRes.json(),
listsRes.json(),
allListsRes.json(),
]);

Expand All @@ -81,12 +79,11 @@ export default function ProjectDetailPage({ params }: { params: Promise<{ id: st
setEditName(projectResult.data.name);
setEditDescription(projectResult.data.description || "");

if (listsResult.success) {
setLists(listsResult.data);
}

if (allListsResult.success) {
setAllLists(allListsResult.data);
// OPTIMIZATION: Derive project-specific lists in-memory from allLists
// instead of making a duplicate backend database query.
setLists(allListsResult.data.filter((list: List) => list.projectId === projectId));
Comment on lines 82 to +86

@coderabbitai coderabbitai Bot Jun 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Handle /api/lists failure explicitly.

On Line 82, a failed /api/lists response leaves lists/allLists untouched and still clears isLoading, so the page can render stale data or a false “no lists yet” state for a project whose lists never loaded.

Suggested fix 
-      if (allListsResult.success) {
-        setAllLists(allListsResult.data);
-        // OPTIMIZATION: Derive project-specific lists in-memory from allLists
-        // instead of making a duplicate backend database query.
-        setLists(allListsResult.data.filter((list: List) => list.projectId === projectId));
-      }
+      if (!allListsResult.success) {
+        setAllLists([]);
+        setLists([]);
+        setError(allListsResult.error || "Failed to load project lists");
+        return;
+      }
+
+      setAllLists(allListsResult.data);
+      // OPTIMIZATION: Derive project-specific lists in-memory from allLists
+      // instead of making a duplicate backend database query.
+      setLists(allListsResult.data.filter((list: List) => list.projectId === projectId));
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
if (allListsResult.success) {
setAllLists(allListsResult.data);
// OPTIMIZATION: Derive project-specific lists in-memory from allLists
// instead of making a duplicate backend database query.
setLists(allListsResult.data.filter((list: List) => list.projectId === projectId));
if (!allListsResult.success) {
setAllLists([]);
setLists([]);
setError(allListsResult.error || "Failed to load project lists");
return;
}
setAllLists(allListsResult.data);
// OPTIMIZATION: Derive project-specific lists in-memory from allLists
// instead of making a duplicate backend database query.
setLists(allListsResult.data.filter((list: List) => list.projectId === projectId));
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/app/projects/`[id]/page.tsx around lines 82 - 86, The project page’s
list-loading flow in page.tsx only updates state on success, so a failed
/api/lists request leaves allLists and lists stale while isLoading is cleared.
Update the fetch handling around the /api/lists response so the failure branch
explicitly resets or clears the project list state and records an error/loading
state before exiting the async path, using the existing projectId, setAllLists,
setLists, and setIsLoading logic.

}
} catch (err) {
console.error("Error fetching project:", err);
Expand Down
Loading