Skip to content

🎨 Palette: [UX improvement] Add context-aware ARIA labels to citation actions#209

Open
aicoder2009 wants to merge 1 commit into
mainfrom
palette-fix-citation-btn-a11y-11288176139078328370
Open

🎨 Palette: [UX improvement] Add context-aware ARIA labels to citation actions#209
aicoder2009 wants to merge 1 commit into
mainfrom
palette-fix-citation-btn-a11y-11288176139078328370

Conversation

@aicoder2009

@aicoder2009 aicoder2009 commented Jul 3, 2026

Copy link
Copy Markdown
Owner

What: Added context-rich aria-label attributes to the various text-based action buttons in the SortableCitation component (e.g., [copy], [edit], [delete], [share], [add], [remove]).
Why: These components use shorthand generic text within brackets. For screen reader users navigating a list of citations, repeatedly hearing just "edit, button" or "add, button" lacks context and creates an ambiguous, frustrating experience. Adding context ensures screen readers announce the button's explicit function.
Before/After:
Before: Screen readers read [edit] -> "edit, button".
After: Screen readers read [edit] -> "Edit citation, button" or "Edit notes, button", depending on the context.
Accessibility: This directly improves accessibility for screen reader users by providing descriptive context to generically-labeled visual text buttons inside lists, complying with best practices for assistive technology and satisfying internal known accessibility learnings.


PR created automatically by Jules for task 11288176139078328370 started by @aicoder2009

Summary by CodeRabbit

  • Bug Fixes
    • Improved accessibility labels on citation action buttons, making copy, edit, share, delete, note, quote, and tag controls easier to use with assistive technologies.

Co-authored-by: aicoder2009 <127642633+aicoder2009@users.noreply.github.com>
@vercel

vercel Bot commented Jul 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
opencitation Ready Ready Preview, Comment Jul 3, 2026 11:17am

@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings July 3, 2026 11:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 4c940758-3764-408f-be3d-171671ede7d8

📥 Commits

Reviewing files that changed from the base of the PR and between b69285b and f44059e.

📒 Files selected for processing (1)
  • src/components/wiki/sortable-citation.tsx

📝 Walkthrough

Walkthrough

This PR adds aria-label attributes to action buttons throughout the SortableCitation component, covering citation copy/edit/share/delete controls, notes actions, quote management buttons, and tag input/suggestion buttons. No logic, data flow, or exported entity signatures are changed.

Changes

Accessibility labeling

Layer / File(s) Summary
Citation action labels
src/components/wiki/sortable-citation.tsx
Added `aria-label` to copy citation, copy in-text citation, edit, share, and delete buttons.
Notes action labels
src/components/wiki/sortable-citation.tsx
Added `aria-label` to edit, clear, and add notes buttons.
Quotes action labels
src/components/wiki/sortable-citation.tsx
Added `aria-label` to remove/add quote buttons and the edit-quotes/no-quotes add-quote buttons.
Tags action labels
src/components/wiki/sortable-citation.tsx
Added `aria-label` to add-tag, cancel, tag-suggestion, and non-editing add-tag buttons.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main accessibility change by adding context-aware ARIA labels to citation actions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette-fix-citation-btn-a11y-11288176139078328370

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants