feat: vendor pyscss so that re is fixed for py3#121
Closed
shwoodard wants to merge 1 commit intoaip-dev:masterfrom
Closed
feat: vendor pyscss so that re is fixed for py3#121shwoodard wants to merge 1 commit intoaip-dev:masterfrom
shwoodard wants to merge 1 commit intoaip-dev:masterfrom
Conversation
Given that [the pyscss library](https://github.com/Kronuz/pyScss) will not release version 1.4.1 to PyPI ([PR](Kronuz/pyScss#430)), this commit vendors the library into the repo, including the LICENSE file for compliance. The fix for the re is included. The commit does the following: * Vendor pyscss 1.4.0 * Fixes the regex error in expression.py with a comment that links to the PR that does the same. * Remove the download from setup.py * Add the vendored files to the MANIFEST so that they are installed with pip for gh-pages * Add the vendor dir's children that are directories to the import path so that "scss" is seen.
shwoodard
force-pushed
the
vendor-pyscss
branch
from
2db9ef3 to
eb45d30
Compare
Contributor
Author
|
Closing this since vendoring is not recommended by the pip team. Suggest using from fork like in #122. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that the pyscss library will not release version 1.4.1 to PyPI (PR), this commit vendors the library into the repo, including the LICENSE file for compliance. The fix for the re is included.
This is to pave the way to allow us to update outdated dependencies
The commit does the following: