feat(notebook): import ipynb sessions - #309
Open
imjszhang wants to merge 3 commits into
Open
Conversation
This was referenced Jul 22, 2026
imjszhang
force-pushed
the
feat/ipynb-import
branch
2 times, most recently
from
July 22, 2026 15:28
ee67446 to
3b8e10b
Compare
1 task
cursor
Bot
force-pushed
the
feat/ipynb-import
branch
from
July 23, 2026 06:07
3b8e10b to
069a5ad
Compare
cursor Bot
pushed a commit
to imjszhang/open-science
that referenced
this pull request
Jul 23, 2026
Rebased onto upstream main and stacked on import (aipoch#309). Ensures JupyterLab is available in the session Python runtime, projects the session into its data root, launches JupyterLab without a browser, and reaps process trees on shutdown. Part of aipoch#293 Co-authored-by: JS <imjszhang@users.noreply.github.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
imjszhang
force-pushed
the
feat/ipynb-import
branch
from
July 30, 2026 16:03
069a5ad to
c594cb4
Compare
…erns Wrap import in withDataRootWrite, use dialogSession for the picker flow, and surface import success plus an imported badge. Co-authored-by: Cursor <cursoragent@cursor.com>
Return recorded-vs-bound env mismatches from importIpynb for the footer, and align Preview/Dialog imported badges with a re-run tooltip. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
importednotebook run records without changing the append-only storage modelimportIpynbinwithDataRootWrite, usedialogSessionfor the import request, show import success in the footer, and badgeimportedrunsenvironmentis historical annotation only (runCell still uses the session binding); import does not write artifact provenance / inputFiles; markdown/raw cells remain skippedenvironmentNoticewhen recorded env differs from the bound runtime (footer), add re-run tooltip on Dialog/PreviewimportedbadgesPart of #293
Test plan
npm run check:web-api-mapnpm test -- src/main/notebook/ipynb-import.test.ts src/main/notebook/runtime-service.import.test.ts src/main/notebook/ipc.test.ts src/renderer/src/pages/workspace/SessionNotebookDialog.render.test.tsx src/renderer/src/pages/workspace/SessionNotebookDialog.interaction.test.tsx src/renderer/src/pages/workspace/NotebookPreview.cell.render.test.tsxnpm run typecheck(local env missing some deps / generated Prisma client; unrelated to this diff)