Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
"fflate": "0.8.3",
"js-tiktoken": "^1.0.21",
"js-yaml": "^4.1.0",
"marked": "^17.0.6",
"openchemlib": "^9.24.0",
"pdfjs-dist": "5.4.624",
"tar": "^7.5.20",
Expand Down
9 changes: 9 additions & 0 deletions src/main/ipc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,10 @@ import {
loadSessionsAfterProjectRecovery,
registerSessionPersistenceIpcHandlers
} from './session-persistence/ipc'
import {
createConversationExportService,
registerConversationExportIpcHandler
} from './session-persistence/conversation-export'
import { registerProjectFilesIpcHandlers } from './project-files/ipc'
import { createManagedFileIndexRepository } from './project-files/repository'
import { ProjectDeletionCoordinator } from './projects/deletion-coordinator'
Expand Down Expand Up @@ -882,6 +886,11 @@ const registerIpcHandlers = async ({
notebookInputRegistry.readPreview(request)
)
registerSessionPersistenceIpcHandlers(sessionPersistenceBackend, reviewRepository)
registerConversationExportIpcHandler(
createConversationExportService({
loadSession: (projectId, sessionId) => sessionRepository.loadSession(projectId, sessionId)
})
)
registerProjectFilesIpcHandlers(
projectFilesRepository,
sessionPersistenceCoordinator,
Expand Down
256 changes: 256 additions & 0 deletions src/main/session-persistence/conversation-export.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,256 @@
import { beforeEach, describe, expect, it, vi } from 'vitest'

import type { PersistedChatSession } from '../../shared/session-persistence'

const { fromWebContents, ipcHandlers } = vi.hoisted(() => ({
fromWebContents: vi.fn(),
ipcHandlers: new Map<string, (...args: unknown[]) => unknown>()
}))

vi.mock('electron', () => ({
app: { getPath: vi.fn() },
BrowserWindow: Object.assign(vi.fn(), { fromWebContents }),
dialog: { showSaveDialog: vi.fn() },
ipcMain: {
handle: (channel: string, handler: (...args: unknown[]) => unknown) =>
ipcHandlers.set(channel, handler)
}
}))

import {
createConversationExportService,
registerConversationExportIpcHandler
} from './conversation-export'

const session: PersistedChatSession = {
id: 'session-1',
projectId: 'project-1',
title: 'Export test',
cwd: '/workspace',
status: 'idle',
messages: [
{
id: 'message-1',
role: 'user',
content: 'Hello',
status: 'complete',
eventIds: [],
createdAt: 1,
updatedAt: 1
}
],
createdAt: 1,
updatedAt: 2
}

describe('conversation export service', () => {
const loadSession = vi.fn()
const showSaveDialog = vi.fn()
const writeExportFile = vi.fn()
const createTempDirectory = vi.fn()
const removeDirectory = vi.fn()
const executeJavaScript = vi.fn()
const printToPDF = vi.fn()
const loadFile = vi.fn()
const destroy = vi.fn()
const createPrintWindow = vi.fn(() => ({
loadFile,
webContents: { executeJavaScript, printToPDF },
destroy
}))

beforeEach(() => {
vi.clearAllMocks()
loadSession.mockResolvedValue(session)
showSaveDialog.mockResolvedValue({ canceled: false, filePath: '/downloads/export.md' })
writeExportFile.mockResolvedValue(undefined)
createTempDirectory.mockResolvedValue('/tmp/open-science-conversation-export-test')
removeDirectory.mockResolvedValue(undefined)
loadFile.mockResolvedValue(undefined)
executeJavaScript.mockResolvedValue(true)
printToPDF.mockResolvedValue(Buffer.from('pdf'))
})

const createService = (): ReturnType<typeof createConversationExportService> =>
createConversationExportService({
loadSession,
showSaveDialog,
writeFile: writeExportFile,
createTempDirectory,
removeDirectory,
createPrintWindow,
getDownloadsPath: () => '/downloads',
getTempPath: () => '/tmp',
now: () => 3
})

it('loads the durable session and saves normalized Markdown', async () => {
const result = await createService().exportConversation({
projectId: 'project-1',
sessionId: 'session-1',
format: 'markdown'
})

expect(loadSession).toHaveBeenCalledWith('project-1', 'session-1')
expect(showSaveDialog).toHaveBeenCalledWith(
undefined,
expect.objectContaining({
defaultPath: '/downloads/Export test.md',
filters: [{ name: 'Markdown', extensions: ['md'] }]
})
)
expect(writeExportFile).toHaveBeenCalledWith(
'/downloads/export.md',
expect.stringContaining('# Export test')
)
expect(createPrintWindow).not.toHaveBeenCalled()
expect(result).toEqual({ saved: true, filePath: '/downloads/export.md' })
})

it('prints dedicated HTML to PDF and always destroys the hidden window', async () => {
showSaveDialog.mockResolvedValue({ canceled: false, filePath: '/downloads/export.pdf' })

const result = await createService().exportConversation({
projectId: 'project-1',
sessionId: 'session-1',
format: 'pdf'
})

expect(createTempDirectory).toHaveBeenCalledWith('/tmp/open-science-conversation-export-')
expect(writeExportFile).toHaveBeenNthCalledWith(
1,
'/tmp/open-science-conversation-export-test/conversation.html',
expect.stringContaining('<!doctype html>')
)
expect(loadFile).toHaveBeenCalledWith(
'/tmp/open-science-conversation-export-test/conversation.html'
)
expect(executeJavaScript).toHaveBeenCalledOnce()
expect(printToPDF).toHaveBeenCalledWith(
expect.objectContaining({ pageSize: 'A4', printBackground: true })
)
expect(writeExportFile).toHaveBeenNthCalledWith(2, '/downloads/export.pdf', Buffer.from('pdf'))
expect(destroy).toHaveBeenCalledOnce()
expect(removeDirectory).toHaveBeenCalledWith('/tmp/open-science-conversation-export-test')
expect(result).toEqual({ saved: true, filePath: '/downloads/export.pdf' })
})

it('destroys the print window when PDF generation fails', async () => {
showSaveDialog.mockResolvedValue({ canceled: false, filePath: '/downloads/export.pdf' })
printToPDF.mockRejectedValue(new Error('print failed'))

await expect(
createService().exportConversation({
projectId: 'project-1',
sessionId: 'session-1',
format: 'pdf'
})
).rejects.toThrow('print failed')
expect(destroy).toHaveBeenCalledOnce()
expect(removeDirectory).toHaveBeenCalledWith('/tmp/open-science-conversation-export-test')
})

it('removes the temporary directory when writing the print document fails', async () => {
showSaveDialog.mockResolvedValue({ canceled: false, filePath: '/downloads/export.pdf' })
writeExportFile.mockRejectedValueOnce(new Error('temporary write failed'))

await expect(
createService().exportConversation({
projectId: 'project-1',
sessionId: 'session-1',
format: 'pdf'
})
).rejects.toThrow('temporary write failed')
expect(createPrintWindow).not.toHaveBeenCalled()
expect(removeDirectory).toHaveBeenCalledWith('/tmp/open-science-conversation-export-test')
})

it('does no rendering or writing when Save As is canceled', async () => {
showSaveDialog.mockResolvedValue({ canceled: true })

await expect(
createService().exportConversation({
projectId: 'project-1',
sessionId: 'session-1',
format: 'pdf'
})
).resolves.toEqual({ saved: false })
expect(createPrintWindow).not.toHaveBeenCalled()
expect(writeExportFile).not.toHaveBeenCalled()
})

it('rejects missing, empty, active and malformed conversations', async () => {
loadSession.mockResolvedValueOnce(undefined)
await expect(
createService().exportConversation({
projectId: 'project-1',
sessionId: 'missing',
format: 'markdown'
})
).rejects.toThrow('Conversation not found.')

loadSession.mockResolvedValueOnce({ ...session, messages: [] })
await expect(
createService().exportConversation({
projectId: 'project-1',
sessionId: 'session-1',
format: 'markdown'
})
).rejects.toThrow('no messages')

loadSession.mockResolvedValueOnce({ ...session, status: 'running' })
await expect(
createService().exportConversation({
projectId: 'project-1',
sessionId: 'session-1',
format: 'pdf'
})
).rejects.toThrow('finish before exporting')

loadSession.mockResolvedValueOnce({ ...session, status: 'waiting-permission' })
await expect(
createService().exportConversation({
projectId: 'project-1',
sessionId: 'session-1',
format: 'markdown'
})
).rejects.toThrow('finish before exporting')

await expect(
createService().exportConversation({
projectId: '',
sessionId: 'session-1',
format: 'markdown'
})
).rejects.toThrow('Invalid conversation export request.')
expect(showSaveDialog).not.toHaveBeenCalled()
})
})

describe('conversation export IPC handler', () => {
beforeEach(() => {
ipcHandlers.clear()
fromWebContents.mockReset()
})

it('registers the export channel and forwards the request with its parent window', async () => {
const request = {
projectId: 'project-1',
sessionId: 'session-1',
format: 'pdf' as const
}
const sender = { id: 7 }
const parentWindow = { id: 8 }
const exportConversation = vi.fn().mockResolvedValue({ saved: false })
fromWebContents.mockReturnValue(parentWindow)

registerConversationExportIpcHandler({ exportConversation })

expect([...ipcHandlers.keys()]).toEqual(['sessions:export-conversation'])
await expect(
ipcHandlers.get('sessions:export-conversation')?.({ sender }, request)
).resolves.toEqual({ saved: false })
expect(fromWebContents).toHaveBeenCalledWith(sender)
expect(exportConversation).toHaveBeenCalledWith(request, parentWindow)
})
})
Loading
Loading