Skip to content

Add wallet labels, display master fingerprint and fix Windows build#297

Closed
pauloneo wants to merge 5 commits into
airgap-it:masterfrom
pauloneo:master
Closed

Add wallet labels, display master fingerprint and fix Windows build#297
pauloneo wants to merge 5 commits into
airgap-it:masterfrom
pauloneo:master

Conversation

@pauloneo

@pauloneo pauloneo commented Jul 8, 2026

Copy link
Copy Markdown

Summary

This PR includes three improvements.

1. Windows build fix

Problem
The Android build generated an invalid public/assets/protocol_modules structure on Windows because the namespace was extracted using module.path.split('/'), which does not work with Windows path separators ().

Solution
Replaced the namespace extraction with path.basename(module.path), which works correctly on both Windows and Linux.


2. Master Fingerprint display

Problem
When multiple wallets are created from the same mnemonic using different BIP-39 passphrases, users cannot easily verify which wallet they are viewing.

Solution
Display the wallet Master Fingerprint on the account details screen, allowing users to verify the correct wallet.


3. Custom wallet labels

Problem
When multiple accounts use the same protocol (for example several Bitcoin SegWit wallets), the account list only displays the protocol name and address, making it difficult to distinguish them.

Solution
Added support for custom wallet labels:

  • enter a label when creating a wallet;
  • persist the label during wallet serialization;
  • restore the label when deserializing the wallet;
  • display the label in the account list below the protocol name.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

💡 Need a hand with PR review? Try Gitar by Sonar!

@pauloneo pauloneo changed the title Fix Windows path handling for builtin protocol modules Add wallet labels, display master fingerprint and fix Windows build Jul 10, 2026
@pauloneo pauloneo closed this Jul 15, 2026
@pauloneo

Copy link
Copy Markdown
Author

This PR has been replaced by #299, which includes the same changes plus the Sonar fixes.

Closing this one to avoid duplicate pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant