Conversation
|
This makes subsequent Trino builds faster (even when cleaned): After: Before: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Maven configuration adds a version-keyed Checkstyle cache path and assigns it to the Merge Risk: ⚪ Minimal · up to The change moves the Checkstyle cache into a version-keyed project-root directory and ignores it from source control; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 89836248-39aa-4f90-aebe-e9992a2cab40
📒 Files selected for processing (1)
airbase/pom.xml
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.
c187f9d to
77716d4
Compare
77716d4 to
5611aec
Compare
| <!-- checkout-specific so concurrent builds of separate checkouts never share --> | ||
| <!-- a cache file (Checkstyle rewrites it without locking), and keyed by the --> | ||
| <!-- Checkstyle version since the cache does not track the version on its own. --> | ||
| <air.checkstyle.cache-file>${maven.multiModuleProjectDirectory}/.checkstyle-cache/${project.groupId}/${project.artifactId}-${dep.checkstyle.version}.cache</air.checkstyle.cache-file> |
There was a problem hiding this comment.
I like quicker builds. And I very much dislike how much time checkstyle takes on a clean (Trino) biuld.
But i also like the fact that "clean && build" is "a clean build", from well defined state. It could be very confusing if someone couldn't reproduce a CI failure despite running ./mvnw clean first.
I know the problem is pre-existing because of .node and node_modules directories, but I am not convinced the gain is worth the added complexity.
Maybe we should hear others opinion before merging?
There was a problem hiding this comment.
Why would I need to "reproduce CI failure" around checkstyle?

Airbase contribution check list