fix(operators): honor nodeSelector/tolerations/affinity values#563
Merged
Conversation
The akash-hostname-operator and akash-inventory-operator Deployment templates did not reference nodeSelector/tolerations/affinity, so those values were silently ignored. Adds the standard with/toYaml blocks at the pod spec level (matching the pattern used in akash-provider's StatefulSet). Also adds the three values keys to akash-inventory-operator values.yaml where they were previously missing.
Zblocker64
requested changes
Apr 21, 2026
Zblocker64
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
akash-hostname-operatorandakash-inventory-operatorcharts declarenodeSelector/tolerations/affinityvalues but thetemplates/deployment.yamlin both charts never references those values, so they are silently ignored.This prevents operators from scheduling on clusters where every non-control-plane node is tainted (for example a single ingress-only worker tainted
akash.network/role=ingress:NoSchedule) — there is no way to make Helm emit a toleration onto the pod spec.Fix
Adds the standard
with/toYamlblocks at the bottom ofspec.template.specin both Deployment templates, matching the pattern already used inakash-provider/templates/statefulset.yaml:346-357:Also adds the three keys to
akash-inventory-operator/values.yaml, which were previously missing entirely (onlyakash-hostname-operator/values.yamlhad them declared).Backward compatibility
Empty values render no blocks — existing users see no behavior change. Verified with
helm templateagainst both charts with and without overrides, andhelm lintpasses on both.