Conversation
Signed-off-by: Artur Troian <troian@users.noreply.github.com>
WalkthroughAdds an optional ReclamationWindow duration, wires a CLI flag into provider config, forwards it into bid messages, updates service and lease event handling to account for reclamation state, and bumps dependencies/tests for compatibility. ChangesReclamation Window Configuration and Integration
🎯 3 (Moderate) | ⏱️ ~20 minutes
sequenceDiagram
participant CLI
participant ProviderService
participant BidEngine
participant ClusterService
CLI->>ProviderService: start (reads `reclamation-window` via Viper)
ProviderService->>BidEngine: NewService(cfg with ReclamationWindow)
BidEngine->>BidEngine: order.run builds MsgCreateBid (sets ReclamationWindow)
BidEngine->>ProviderService: broadcast MsgCreateBid (tx)
ClusterService->>ClusterService: receive EventLeaseReclaimStarted (logs leaseID, reason, deadline)
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Around line 347-355: Update the vulnerable OTel SDK modules: change the
versions for go.opentelemetry.io/otel/sdk and
go.opentelemetry.io/otel/sdk/metric to at least v1.43.0 (or a newer compatible
release) so they are aligned with the other otel dependencies (e.g.,
go.opentelemetry.io/otel v1.41.0); after editing the go.mod entries for
go.opentelemetry.io/otel/sdk and go.opentelemetry.io/otel/sdk/metric, run the
module update (e.g., go get ./... or go get go.opentelemetry.io/otel/sdk@v1.43.0
&& go get go.opentelemetry.io/otel/sdk/metric@v1.43.0) and then go mod tidy to
refresh go.sum.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 88344d80-f710-443d-913c-02e756f3ddb0
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (9)
bidengine/config.gobidengine/order.gocluster/manager.gocluster/service.gocmd/provider-services/cmd/flags.gocmd/provider-services/cmd/run.goconfig.gogo.modservice.go
Align the E2E oracle setup with the oracle v2 module used by pkg.akt.dev/node/v2 so genesis interception can unmarshal the oracle state. Also align the Akash Cosmos SDK fork replacement with the declared v0.53.6 requirement. Signed-off-by: Joseph Chalabi <chalabi.joseph@gmail.com>
Fail fast when the reclamation window flag is set below zero. Zero remains the disabled value, and positive values continue to advertise a reclamation window in bids. Signed-off-by: Joseph Chalabi <chalabi.joseph@gmail.com>
Description
Adds provider support for resource reclamation. Providers can advertise a reclamation window in bids, leases in the reclaiming state continue running during that window, and the cluster service waits for the close event before tearing workloads down.
This also aligns the provider dependency replacement for the Cosmos SDK Akash fork with the declared v0.53.6 requirement and updates the E2E oracle setup to use the oracle v2 types used by pkg.akt.dev/node/v2.
Tests