Fix Json-CRITICAL assertions when parsing empty JSON data - #2647
Draft
irakligorgadze wants to merge 1 commit into
Draft
Fix Json-CRITICAL assertions when parsing empty JSON data#2647irakligorgadze wants to merge 1 commit into
irakligorgadze wants to merge 1 commit into
Conversation
JsonUtils.get_object() and Source's from_json constructors called parser.get_root().get_object() without checking if get_root() returned a valid node. Empty string input parses without error but yields no root node, triggering GLib CRITICAL assertions on every fresh install before any account/backup data exists.
byquanton
reviewed
Aug 27, 2026
| } | ||
| var object = root.get_object (); | ||
| if (object.has_member ("access_token")) { | ||
| access_token = object.get_string_member ("access_token"); |
Collaborator
There was a problem hiding this comment.
Why do you remove this ?
byquanton
marked this pull request as draft
August 27, 2026 16:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JsonUtils.get_object() and Source's from_json constructors called parser.get_root().get_object() without checking if get_root() returned a valid node. Empty string input parses without error but yields no root node, triggering GLib CRITICAL assertions on every fresh install before any account/backup data exists.
Tested on Arch (Omarchy), built from main. Reproduced with a fresh
rm -rf ~/.local/share/io.github.alainm23.planify ~/.config/io.github.alainm23.planify,
confirmed the CRITICAL lines are gone after this fix.