Skip to content

feat: add integration testing suite for OpenAI endpoints#50

Merged
alez007 merged 1 commit intomainfrom
feat/integration-tests
May 1, 2026
Merged

feat: add integration testing suite for OpenAI endpoints#50
alez007 merged 1 commit intomainfrom
feat/integration-tests

Conversation

@alez007
Copy link
Copy Markdown
Owner

@alez007 alez007 commented May 1, 2026

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive integration test suite for the modelship service, covering chat completions, streaming, tool calling, embeddings, and audio processing. It also adds a tool_call_parser field to the TransformersConfig and registers an integration marker in pyproject.toml. Key feedback includes fixing a bug where signal constants were incorrectly accessed via the subprocess module, replacing the deprecated preexec_fn with start_new_session, and improving test robustness by using the tmp_path fixture and relative pathing for configuration files.

Comment thread tests/test_integration.py
Comment thread tests/test_integration.py Outdated
Comment thread tests/test_integration.py Outdated
Comment thread tests/test_integration.py Outdated
Comment thread modelship/infer/infer_config.py
Comment thread tests/test_integration.py Outdated
Comment thread tests/test_integration.py Outdated
Comment thread tests/test_integration.py Outdated
@alez007 alez007 force-pushed the feat/integration-tests branch from 06b1752 to 1a5c638 Compare May 1, 2026 17:42
@alez007 alez007 merged commit a508848 into main May 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant