Skip to content

feat(starrocks): support setting scheme (http or https) for data loading url #2345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaogoy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(starrocks): support setting scheme (http or https) for data loading url #2345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 24 additions & 5 deletions ...cks/connector/datax/plugin/writer/starrockswriter/manager/StarRocksStreamLoadVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
import java.util.concurrent.TimeUnit;
import java.util.stream.Collectors;


public class StarRocksStreamLoadVisitor {

private static final Logger LOG = LoggerFactory.getLogger(StarRocksStreamLoadVisitor.class);
Expand Down Expand Up @@ -104,16 +104,35 @@ private String getAvailableHost() {
List<String> hostList = writerOptions.getLoadUrlList();
long tmp = pos + hostList.size();
for (; pos < tmp; pos++) {
String host = new StringBuilder("http://").append(hostList.get((int) (pos % hostList.size()))).toString();
String rawHost = hostList.get((int) (pos % hostList.size()));
String host = normalizeHostScheme(rawHost);
if (tryHttpConnection(host)) {
return host;
}
}
return null;
}

private String normalizeHostScheme(String host) {
if (host == null) {
return null;
}
String trimmed = host.trim();
if (trimmed.isEmpty()) {
return trimmed;
}
if (hasScheme(trimmed)) {
return trimmed;
}
return "http://" + trimmed;
}

private boolean hasScheme(String host) {
return host.matches("^[a-zA-Z][a-zA-Z0-9+\\-.]*://.*");
}

private boolean tryHttpConnection(String host) {
try {
try {
URL url = new URL(host);
HttpURLConnection co = (HttpURLConnection) url.openConnection();
co.setConnectTimeout(1000);
Expand All @@ -137,7 +156,7 @@ private byte[] joinRows(List<byte[]> rows, int totalBytes) {
}
return bos.array();
}

if (StarRocksWriterOptions.StreamLoadFormat.JSON.equals(writerOptions.getStreamLoadFormat())) {
ByteBuffer bos = ByteBuffer.allocate(totalBytes + (rows.isEmpty() ? 2 : rows.size() + 1));
bos.put("[".getBytes(StandardCharsets.UTF_8));
Expand Down Expand Up @@ -274,7 +293,7 @@ private HttpEntity getHttpEntity(CloseableHttpResponse resp) {
}
return respEntity;
}

private String doHttpGet(String getUrl) throws IOException {
LOG.info("Executing GET from {}.", getUrl);
try (CloseableHttpClient httpclient = buildHttpClient()) {
Expand Down