Separate rawQuery from url path for srv format URI#969
Open
anisurrahman75 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Anisur Rahman <anisur@appscode.com>
|
|
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates MongoDB URI handling to better support mongodb+srv:// by separating RawQuery from the path, and adjusts connection setup accordingly.
Changes:
- Extend
EncodeMongoURIto supportmongodb+srvand to serialize query params viaRawQueryinstead of embedding them inPath. - Update connection initialization to use
mongo.Connectand avoid forcingdirectmode for SRV URIs. - Add a repo config file and a PID file under
logs/.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| mongoshake.conf | Adds a config file with example connection settings (currently includes credentials). |
| logs/mongoshake.pid | Adds a generated PID file to the repo. |
| common/community_client.go | Adds SRV scheme support, modifies URI encoding, and tweaks client connection options. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+3
to
+7
| #mongo_urls = mongodb://root:O249MCkl.~laPeNe@10.2.0.216:30310/?directConnection=true | ||
| #mongo_urls = mongodb://root:O249MCkl.~laPeNe@10.42.0.96:27017,10.42.0.97:27017/?replicaSet=rs1 | ||
| #mongo_urls = mongodb://root:O249MCkl.~laPeNe@127.0.0.1:27017/admin?directConnection=true | ||
| #mongo_urls = mongodb://msuser:MySafePassword123!@127.0.0.1:27018/admin?authSource=admin&directConnection=true | ||
| #tunnel.address = mongodb://root:b841Pt6cOrMppzmX@10.2.0.216:32255 |
|
|
||
| conf.version = 11 | ||
| mongo_urls = | ||
| tunnel.address= mongodb://root:YcYbhFKuCwso~CxL@10.2.0.216:30378 |
| @@ -0,0 +1 @@ | |||
| 144794 | |||
Comment on lines
+88
to
+92
| isSrvURI := strings.HasPrefix(url, "mongodb+srv://") | ||
| clientOps := options.Client().ApplyURI(encodedURL) | ||
| //clientOps := options.Client().ApplyURI(url) | ||
| if !isSrvURI { | ||
| clientOps.SetDirect(true) | ||
| } |
Comment on lines
316
to
328
| hostPathParts := strings.SplitN(afterUserInfo, "/", 2) | ||
| host := hostPathParts[0] | ||
| var path string | ||
|
|
||
| var path, rawQuery string | ||
| if len(hostPathParts) > 1 { | ||
| path = "/" + hostPathParts[1] | ||
| } else { | ||
| path = "" | ||
| pathAndQuery := hostPathParts[1] | ||
| // split path and query | ||
| pathQueryParts := strings.SplitN(pathAndQuery, "?", 2) | ||
| path = "/" + pathQueryParts[0] | ||
| if len(pathQueryParts) > 1 { | ||
| rawQuery = pathQueryParts[1] | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.