fix: wrap timeFragmentMap with Collections.synchronizedMap() for thread safety#3175
Open
srpatcha wants to merge 1 commit intoalibaba:masterfrom
Open
fix: wrap timeFragmentMap with Collections.synchronizedMap() for thread safety#3175srpatcha wants to merge 1 commit intoalibaba:masterfrom
srpatcha wants to merge 1 commit intoalibaba:masterfrom
Conversation
The LinkedHashMap is accessed from multiple threads (advice listeners and command thread) without synchronization, risking ConcurrentModificationException or data corruption. The existing TODO comment acknowledged this concern.
|
Srikanth Patchava seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix thread-unsafe LinkedHashMap in TimeTunnelCommand
Problem
timeFragmentMapinTimeTunnelCommand.javais a plainLinkedHashMapaccessed concurrently from multiple threads (advice listeners writing time fragments + command thread reading/iterating). This can causeConcurrentModificationException, infinite loops in HashMap bucket chains, or silent data corruption.Root Cause
The field is declared as
new LinkedHashMap<Integer, TimeFragment>()with a TODO comment acknowledging the thread-safety concern (// TODO 并非线程安全?— "not thread safe?"). TheAdviceListenercallbacks that populate this map run on instrumented application threads, while command operations (list, search, replay) run on the Arthas command thread.Fix
Replaced
new LinkedHashMap<>()withCollections.synchronizedMap(new LinkedHashMap<>())to provide basic thread safety. Added thejava.util.Collectionsimport.Testing
ttcommand while monitoring a high-throughput method with multiple threads calling it simultaneously.ConcurrentModificationExceptionduringtt -l(list) operations; now it should be safe.Impact
Affects all Arthas users using the Time Tunnel (
tt) command on multi-threaded applications. The bug is non-deterministic and depends on timing, making it difficult to reproduce consistently.