feat(agent): add static runtime preflight - #233
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
| if cfg.Engine.Name == "" { | ||
| errs = append(errs, "engine.name is required") | ||
| } | ||
| if cfg.Engine.Version != "" && agentkind.SupportsVersion(cfg.Engine.Name) && !agentkind.IsExactVersion(cfg.Engine.Version) { |
There was a problem hiding this comment.
Before this change, a v1alpha1 config using engine.version values such as latest or ^1.2.0 passed validation and ran with a warning. The same config now fails for Claude Code, Codex, and Qwen Code, which seems inconsistent with the compatibility statement and the acceptance criteria in #196. Could we keep the previous warn-and-ignore behavior for non-exact versions, or explicitly document this as a breaking change with a migration path?
Summary
runtime: nonehostsCompatibility
engine.versionremains unsupported and is ignoredValidation
make verifymake testmake test-actionmake buildgo test -tags e2e -v -parallel 1 ./e2ePart of #196 (PR 5).