Fix crashes and instabilities: use-after-free, null derefs, UB, unhandled exceptions

src/qtAliceVision/FloatImageViewer.cpp

@@ -589,16 +589,19 @@ QSGNode* FloatImageViewer::updatePaintNode(QSGNode* oldNode, [[maybe_unused]] QQ
     {
         _boundingRect = newBoundingRect;
 
-        const float windowRatio = static_cast<float>(_boundingRect.width()) / static_cast<float>(_boundingRect.height());
-        const float textureRatio = static_cast<float>(_textureSize.width()) / static_cast<float>(_textureSize.height());
         QRectF geometryRect = _boundingRect;
-        if (windowRatio > textureRatio)
+        if (_boundingRect.height() > 0 && _textureSize.height() > 0)
         {
-            geometryRect.setWidth(geometryRect.height() * textureRatio);
-        }
-        else
-        {
-            geometryRect.setHeight(geometryRect.width() / textureRatio);
+            const float windowRatio = static_cast<float>(_boundingRect.width()) / static_cast<float>(_boundingRect.height());
+            const float textureRatio = static_cast<float>(_textureSize.width()) / static_cast<float>(_textureSize.height());
+            if (windowRatio > textureRatio)
+            {
+                geometryRect.setWidth(geometryRect.height() * textureRatio);
+            }
+            else
+            {
+                geometryRect.setHeight(geometryRect.width() / textureRatio);
+            }
         }
         geometryRect.moveCenter(_boundingRect.center());
 

src/qtAliceVision/FloatTexture.cpp

@@ -24,12 +24,19 @@ FloatTexture::~FloatTexture()
 void FloatTexture::setImage(std::shared_ptr<FloatImage>& image)
 {
     _srcImage = image;
-    _textureSize = {_srcImage->width(), _srcImage->height()};
+    if (_srcImage)
+    {
+        _textureSize = {_srcImage->width(), _srcImage->height()};
+    }
+    else
+    {
+        _textureSize = {};
+    }
     _dirty = true;
     _mipmapsGenerated = false;
 }
 
-bool FloatTexture::isValid() const { return _srcImage->width() != 0 && _srcImage->height() != 0; }
+bool FloatTexture::isValid() const { return _srcImage && _srcImage->width() != 0 && _srcImage->height() != 0; }
 
 qint64 FloatTexture::comparisonKey() const { return _rhiTexture ? _rhiTexture->nativeTexture().object : 0; }
 

src/qtAliceVision/ImageCache.cpp

@@ -68,7 +68,9 @@ void ImageCache::cleanup(size_t requestedSize, const CacheKey& toAdd)
                 // After the frameId, the largest the difference, the highest its priority to delete
                 if (diff < 0)
                 {
-                    diff = std::numeric_limits<int>::max() + diff;
+                    // Wrap negative differences to sort them after positive ones.
+                    // Use unsigned arithmetic to avoid signed integer overflow (UB).
+                    diff = static_cast<int>(static_cast<unsigned int>(std::numeric_limits<int>::max()) + static_cast<unsigned int>(diff));
                 }
 
                 orderedKeys[diff] = &key;

src/qtAliceVision/MSfMData.cpp

@@ -71,6 +71,11 @@ void MSfMData::load()
 
 QString MSfMData::getUrlFromViewId(int viewId)
 {
+    if (!_sfmData)
+    {
+        qWarning() << "[QtAliceVision] MSfMData::getUrlFromViewId: no SfMData loaded.";
+        return {};
+    }
     return QString::fromUtf8(_sfmData->getView(aliceVision::IndexT(viewId)).getImage().getImagePath().c_str());
 }
 
@@ -119,6 +124,10 @@ size_t MSfMData::nbCameras() const
 QVariantList MSfMData::getViewsIds() const
 {
     QVariantList viewsIds;
+    if (!_sfmData || _status != Ready)
+    {
+        return viewsIds;
+    }
     for (const auto& id : _sfmData->getValidViews())
     {
         viewsIds.append(id);

src/qtAliceVision/MTracks.cpp

@@ -50,15 +50,11 @@ void TracksDirectIORunnable::run()
 
     if (!aliceVision::track::loadTracks(*tracks, _filename))
     {
-        if (tracks) 
-        {
-            delete tracks;
-        }
+        delete tracks;
+        delete tracksPerView;
 
-        if (tracksPerView)
-        {
-            delete tracksPerView;
-        }
+        Q_EMIT resultReady(nullptr, nullptr);
+        return;
     }
 
     aliceVision::track::computeTracksPerView(*tracks, *tracksPerView);

src/qtAliceVision/MViewStats.cpp

@@ -34,7 +34,8 @@ void MViewStats::fillResidualFullSerie(QXYSeries* residuals)
 
     if (residualHistX.size() != residualHistY.size())
     {
-        throw std::runtime_error("MViewStats::fillResidualFullSerie: residualHistX & residualHistY size mismatch.");
+        qWarning() << "[QtAliceVision] MViewStats::fillResidualFullSerie: residualHistX & residualHistY size mismatch.";
+        return;
     }
     QPen pen(Qt::red, 1, Qt::DashLine, Qt::FlatCap, Qt::BevelJoin);
 
@@ -69,7 +70,8 @@ void MViewStats::fillResidualViewSerie(QXYSeries* residuals)
     std::vector<size_t> residualHistY = _residualHistogramView.GetHist();
     if (residualHistX.size() != residualHistY.size())
     {
-        throw std::runtime_error("MViewStats::fillResidualViewSerie: residualHistX & residualHistY size mismatch.");
+        qWarning() << "[QtAliceVision] MViewStats::fillResidualViewSerie: residualHistX & residualHistY size mismatch.";
+        return;
     }
     QPen pen(Qt::darkBlue, 3, Qt::SolidLine, Qt::FlatCap, Qt::BevelJoin);
 
@@ -104,7 +106,8 @@ void MViewStats::fillObservationsLengthsFullSerie(QXYSeries* observationsLengths
     std::vector<size_t> observationsLengthsHistY = _observationsLengthsHistogramFull.GetHist();
     if (observationsLengthsHistX.size() != observationsLengthsHistY.size())
     {
-        throw std::runtime_error("MViewStats::fillObservationsLengthsFullSerie: observationsLengthsHistX & observationsLengthsHistY size mismatch.");
+        qWarning() << "[QtAliceVision] MViewStats::fillObservationsLengthsFullSerie: observationsLengthsHistX & observationsLengthsHistY size mismatch.";
+        return;
     }
     QPen pen(Qt::red, 1, Qt::DashLine, Qt::FlatCap, Qt::BevelJoin);
 
@@ -139,7 +142,8 @@ void MViewStats::fillObservationsLengthsViewSerie(QXYSeries* observationsLengths
     std::vector<size_t> observationsLengthsHistY = _observationsLengthsHistogramView.GetHist();
     if (observationsLengthsHistX.size() != observationsLengthsHistY.size())
     {
-        throw std::runtime_error("MViewStats::fillObservationsLengthsViewSerie: observationsLengthsHistX & observationsLengthsHistY size mismatch.");
+        qWarning() << "[QtAliceVision] MViewStats::fillObservationsLengthsViewSerie: observationsLengthsHistX & observationsLengthsHistY size mismatch.";
+        return;
     }
     QPen pen(Qt::darkBlue, 3, Qt::SolidLine, Qt::FlatCap, Qt::BevelJoin);
 
@@ -174,7 +178,8 @@ void MViewStats::fillObservationsScaleFullSerie(QXYSeries* observationsScale)
     std::vector<size_t> observationsScaleHistY = _observationsScaleHistogramFull.GetHist();
     if (observationsScaleHistX.size() != observationsScaleHistY.size())
     {
-        throw std::runtime_error("MViewStats::fillObservationsScaleFullSerie: observationsScaleHistX & observationsScaleHistY size mismatch.");
+        qWarning() << "[QtAliceVision] MViewStats::fillObservationsScaleFullSerie: observationsScaleHistX & observationsScaleHistY size mismatch.";
+        return;
     }
     QPen pen(Qt::red, 1, Qt::DashLine, Qt::FlatCap, Qt::BevelJoin);
 
@@ -209,7 +214,8 @@ void MViewStats::fillObservationsScaleViewSerie(QXYSeries* observationsScale)
     std::vector<size_t> observationsScaleHistY = _observationsScaleHistogramView.GetHist();
     if (observationsScaleHistX.size() != observationsScaleHistY.size())
     {
-        throw std::runtime_error("MViewStats::fillObservationsScaleViewSerie: observationsScaleHistX & observationsScaleHistY size mismatch.");
+        qWarning() << "[QtAliceVision] MViewStats::fillObservationsScaleViewSerie: observationsScaleHistX & observationsScaleHistY size mismatch.";
+        return;
     }
     QPen pen(Qt::darkBlue, 3, Qt::SolidLine, Qt::FlatCap, Qt::BevelJoin);
 

src/qtAliceVision/PhongImageViewer.cpp

@@ -267,7 +267,7 @@ void PhongImageViewer::reload()
     }
 
     // check source and normal images dimensions
-    if (responseSourceImage.dim != responseSourceImage.dim)
+    if (responseSourceImage.dim != responseNormalImage.dim)
     {
         clearImages();
         setStatus(EStatus::LOADING_ERROR);

src/qtAliceVision/SequenceCache.cpp

@@ -109,7 +109,7 @@ QPointF SequenceCache::getRamInfo() const
     const auto memInfo = aliceVision::system::getMemoryInfo();
 
     double availableRam = static_cast<double>(memInfo.availableRam) / (1024. * 1024. * 1024.);
-    double contentSize = static_cast<double>(_fetcher.getCacheSize()) / (1024. * 1024. * 1024. * 1024.);
+    double contentSize = static_cast<double>(_fetcher.getCacheSize()) / (1024. * 1024. * 1024.);
 
     // Return in GB
     return QPointF(availableRam, contentSize);

src/qtAliceVision/Surface.hpp

@@ -202,7 +202,7 @@ class Surface : public QObject
     bool _needToUseIntrinsic = true;
 
     // Id View
-    aliceVision::IndexT _idView;
+    aliceVision::IndexT _idView = aliceVision::UndefinedIndexT;
 
     // Viewer
     EViewerType _viewerType = EViewerType::DEFAULT;

src/qtAliceVisionImageIO/QtAliceVisionImageIOHandler.cpp

@@ -79,7 +79,15 @@
 
     qDebug() << "[QtAliceVisionImageIO] Read image: " << path.c_str();
     aliceVision::image::Image<aliceVision::image::RGBColor> img;
-    aliceVision::image::readImage(path, img, aliceVision::image::EImageColorSpace::SRGB);
+    try
+    {
+        aliceVision::image::readImage(path, img, aliceVision::image::EImageColorSpace::SRGB);
+    }
+    catch (const std::exception& e)
+    {
+        qWarning() << "[QtAliceVisionImageIO] Failed to read image:" << e.what();
+        return false;
+    }
 
     oiio::ImageBuf inBuf;
     aliceVision::image::getBufferFromImage(img, inBuf);