feat: native Kotlin step definition support via language-server fork#3
Closed
marton78 wants to merge 2 commits into
Closed
feat: native Kotlin step definition support via language-server fork#3marton78 wants to merge 2 commits into
marton78 wants to merge 2 commits into
Conversation
- Install from github:marton78/language-server#kotlin-support instead of the npm registry; the fork adds proper Kotlin step definition and @ParameterType parsing via tree-sitter-kotlin - Remove the runtime .kt patch (no longer needed; the fork handles it) - Remove version-check logic; GitHub installs are pinned by branch ref Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Zed's npm_install_package treats '/' as a path separator so GitHub shorthand specs cannot be used. The fork is installed globally by the user; the extension finds it via worktree.which(). The npm registry package remains the fallback for users without a global install. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Author
|
Opened against wrong repo — should target thlcodes/zed-extension-cucumber instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
marton78/language-server#kotlin-support(pending upstream merge), which adds native Kotlin/Scala glue file support and two bug fixes.ktmonkey-patch that was previously required; the server now handles Kotlin nativelyNote on installation: Zed's
npm_install_packagetreats/as a path separator so GitHub shorthand specs cannot be used directly. The fork is expected to be installed globally by the user; the extension locates it viaworktree.which(). The npm registry package remains the fallback for users without a global install.Dependency chain
This PR is the final piece of a three-repo chain:
cucumber/language-service#304 — Kotlin tree-sitter parsingcucumber/language-server#140 — glue file discovery + bug fixesOnce PRs #304 and #140 merge and a new
@cucumber/language-serverversion is published, thepackage.jsonreference in this extension can be updated to point at the official npm release.Test plan
🤖 Generated with Claude Code