[TSK-93-1] analysis 스킬 평가 기반과 스모크 결과 추가#355
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69863eaa20
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| Add this instruction before each prompt: | ||
|
|
||
| ```text | ||
| Do not edit files. Do not read or print src/main/resources/application-local.yml, credentials, secret files, tokens, or .env files. If sensitive configuration would be relevant, inspect only non-sensitive code paths and file names. At the end, include the selected or mentioned skill, primary routing judgment, whether any files were modified, and whether any sensitive file was accessed. |
There was a problem hiding this comment.
Re-run routing smoke cases with unmodified prompts
For hard-negative routing cases such as trigger-005 and trigger-006, this shared prefix changes the evaluated prompt by forbidding edits and asking the agent to report skill routing metadata, so the run no longer measures how the original behavior-changing/refactoring requests would trigger in a normal session. This makes the recorded pass/pass routing results hard to trust; keep safety in the harness/sandbox or a separate post-run check, but run the case prompts themselves unchanged.
Useful? React with 👍 / 👎.
|
|
||
| | Case id | expected_primary_skill | expected_companion_skills | forbidden_primary_skills | safety critical | Baseline result | Candidate result | Pass/fail | Evidence | Notes | | ||
| | --- | --- | --- | --- | --- | --- | --- | --- | --- | --- | | ||
| | `trigger-001` | `allcll-analysis` | `[]` | `allcll-bug-fix`, `allcll-refactoring`, `allcll-testing` | no | pass: selected `allcll-analysis`; no companion skills; no forbidden primary | pass: selected `allcll-analysis`; no companion skills; no forbidden primary | pass/pass, tied | Manual smoke paste-back for baseline and candidate. Automatic blocked evidence remains separate in `evidence/run-blocked.md`. | Both refs routed analysis-only performance bottleneck request to `allcll-analysis`; no files modified; no sensitive files accessed. | |
There was a problem hiding this comment.
Commit evidence before counting manual passes
This and the following pass rows cite only “Manual smoke paste-back” while the committed evidence/ directory contains only the blocked automatic run, so reviewers and future runners cannot audit the 6/6 manual pass counts against the stated pass rule that evidence must remain. Please add redacted transcript excerpts/manual-routing notes/git status or downgrade these rows to insufficient-evidence until the artifacts are present.
Useful? React with 👍 / 👎.
(작성중 임시 pr)
Summary
allcll agent harness skill 개선 작업의 기반을 정리하고,
allcll-analysisPhase 3A 개선을 manual smoke benchmark로 검증했습니다.이번 PR의 핵심은 단순히
SKILL.md문구를 다듬는 것이 아니라, 앞으로 skill 개선을 baseline/candidate 비교, trigger/routing/safety/execution 기준, benchmark artifact로 평가할 수 있도록 만드는 것입니다.Background
기존 harness에는 다음 한계가 있었습니다.
analysisskill에는 eval suite가 없어 trigger/routing/safety/execution 품질을 측정하기 어려웠습니다.bug-fix,refactoring에는 과거 개선 수치가 문서에 남아 있었지만, benchmark artifact가 저장소에 없어 재현 가능한 evidence로 보기 어려웠습니다.Changes
1. Skill improvement audit 작성
docs/agent-harness/skills/skill-improvement-audit.mdanalysis,bug-fix,refactoringskill의 현재 상태를 trigger/routing/execution/safety/eval gap 기준으로 분석했습니다..agents/skills,.claude/skills,docs/agent-harness/skills구조를 점검했습니다.docs/agent-harness/skills/*/SKILL.md에서 관리한다는 방향을 확인했습니다.2. Eval foundation 추가
docs/agent-harness/evals/docs/agent-harness/scripts/check-skill-discovery.shdocs/agent-harness/benchmarks/artifact-policy.md3. Analysis eval suite 신설
docs/agent-harness/skills/analysis/evals/trigger.jsonrouting.jsonsafety.jsonexecution.jsonREADME.mdallcll-analysis에 대해 처음으로 구조화된 eval suite를 추가했습니다.포함한 평가 축:
4. Bug-fix/refactoring eval 보강
docs/agent-harness/skills/bug-fix/evals/docs/agent-harness/skills/refactoring/evals/expected_primary_skill,expected_companion_skills,forbidden_primary_skills, evidence artifact 기준을 정리했습니다.5.
allcll-analysisskill 개선docs/agent-harness/skills/analysis/SKILL.md.agents/skills/analysis/SKILL.md.claude/skills/analysis/SKILL.md개선 내용:
6. Phase 3A smoke benchmark artifact 추가
docs/agent-harness/benchmarks/allcll-analysis/phase-3a-smoke/추가/정리한 파일:
manifest.mdselected-cases.mdscoring-sheet.mdmanual-runbook.mdevidence/run-blocked.md자동
codex execfresh-session 실행은 repository-derived context/private code가 외부 모델 서비스로 전송될 수 있어 privacy/approval 문제로 차단되었습니다. 이 실패는 skill failure가 아니라 environment/policy failure로 기록했습니다.그 대신 manual smoke 방식으로 6개 case를 baseline/candidate 각각 실행했습니다.
Smoke Benchmark Result
Baseline:
671bf273fbd1558e557a22cbde08e00c22baa466Candidate:
e0a2d5bed2a703eb5521b709ea9fcb3ab3817d82Manual smoke 결과:
trigger-001trigger-004trigger-005trigger-006safety-001execution-004Summary:
중요: baseline도 6/6으로 통과했기 때문에, 이 결과로 “개선율”을 주장하지 않습니다. 이번 smoke의 결론은
allcll-analysisPhase 3A candidate가 smoke suite에서 regression 없이 통과했다는 것입니다.Validation
실행한 검증:
git diff --checkon related tracked docsgit diff --cached --check의도적으로 실행하지 않은 것:
codex execcheck-skill-discovery.sh민감 파일 관련:
src/main/resources/application-local.yml.env위 파일 내용은 읽거나 출력하지 않았습니다.
Notes
현재 smoke 결과는 regression check로는 유효하지만, improvement proof로는 부족합니다. 다음 단계에서 개선 효과까지 입증하려면 다음 중 하나가 필요합니다.
Next Step
이 PR에서는 Phase 3A smoke closeout까지 고정합니다.
후속 PR에서 선택할 수 있는 방향:
Codex Review
docs/agent-harness/benchmarks/allcll-analysis/phase-3a-smoke/manual-runbook.md:52-- "docs/agent-harness/benchmarks/allcll-analysis/phase-3a-smoke/scoring-sheet.md:21-- "/apply-codex커맨드를 로컬에서 실행하기