Skip to content

Use consistent key in split #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danog wants to merge 3 commits into
base: 2.x
Choose a base branch
from
Open

Use consistent key in split #113

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f5a9fbf
Use consistent keys in split
danog Oct 16, 2024
464d2ba
Cleanup
danog Oct 16, 2024
72bd47e
Add testcase
danog Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,10 @@ function split(ReadableStream $source, string $delimiter, ?Cancellation $cancell
$split = \explode($delimiter, $buffer);
$buffer = \array_pop($split);

yield from $split;
// Don't use yield from to avoid reusing the keys from $split
foreach ($split as $v) {
yield $v;
}
}

if ($buffer !== '') {
Expand Down