Skip to content

Return static in methods that return self<T> #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vudaltsov wants to merge 1 commit into
base: 1.x
Choose a base branch
from
Open

Return static in methods that return self<T> #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Pipeline.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ public function __destruct()
}
}

public function buffer(int $bufferSize): self
public function buffer(int $bufferSize): static
{
if ($bufferSize < 0) {
throw new \ValueError('Argument #1 ($bufferSize) must be non-negative, got ' . $bufferSize);
Expand All @@ -163,7 +163,7 @@ public function buffer(int $bufferSize): self
return $this;
}

public function concurrent(int $concurrency): self
public function concurrent(int $concurrency): static
{
if ($concurrency < 1) {
throw new \ValueError('Argument #1 ($concurrency) must be positive, got ' . $concurrency);
Expand All @@ -174,19 +174,19 @@ public function concurrent(int $concurrency): self
return $this;
}

public function sequential(): self
public function sequential(): static
{
return $this->concurrent(1);
}

public function ordered(): self
public function ordered(): static
{
$this->ordered = true;

return $this;
}

public function unordered(): self
public function unordered(): static
{
$this->ordered = false;

Expand Down
Loading