Clean up vestigial mypy/type-stub deps now covered by additional_dependencies#306
Merged
Merged
Conversation
…ndencies The mirrors-mypy pre-commit hook installs its own pinned mypy into an isolated venv, so a bare `mypy` pin in test-requirements.txt is never what CI actually runs. Move type-stub packages (types-*, mypy-boto3-*, etc.) into the hook's additional_dependencies where they belong. Co-authored-by: Claude <noreply@anthropic.com>
jconstance-amplify
marked this pull request as ready for review
July 18, 2026 17:20
brandonmontijo
approved these changes
Jul 18, 2026
jconstance-amplify
marked this pull request as draft
July 18, 2026 17:25
jconstance-amplify
marked this pull request as ready for review
July 18, 2026 17:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mechanical cleanup: these repos already run mypy via the
pre-commit/mirrors-mypyhook, but still carried a vestigial
mypypin (and in some cases boto3 type-stubpackages) in requirements/test-requirements files left over from before that hook
existed. Per eng-guidance:pre-commit,
type stubs belong in the hook's
additional_dependencies, not requirements files.Changes:
mypypin (the hook installs its own pinned mypy into an isolated venv)types-*/mypy-boto3-*/boto3-stubspackages intoadditional_dependencies, deduped against what was already declared therepython-hcl2only: bump the mirrors-mypy rev off a pre-v1.0 pin and drop the accompanyinglanguage_versionworkaround (the typed-ast/Python-3.12-wheel issue that pin exists for)codebuild_slack_notifieronly: drop a redundantmypy .invocation from tox's lint testenv, now superseded by the hookGenerated with assistance from Claude Code; see the commit trailer for co-authorship.