Skip to content

fix(analytics-browser): guard snippet bootstrap against undefined _iq and _q #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mercy811 wants to merge 2 commits into
base: main
Choose a base branch
from
+29 −4
Open

fix(analytics-browser): guard snippet bootstrap against undefined _iq and _q #1763

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc11e22
fix(analytics-browser): guard snippet bootstrap against undefined _iq…
Mercy811 May 16, 2026
c7f45fe
fix(analytics-browser): address review feedback on snippet bootstrap …
Mercy811 May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/analytics-browser/src/gtm-snippet-index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import { runQueuedFunctions } from './utils/snippet-helper';
GlobalScope.amplitudeGTM._q = [];
runQueuedFunctions(amplitudeGTM, queue);

const instanceNames = Object.keys(GlobalScope.amplitudeGTM._iq) || [];
const instanceNames = Object.keys(GlobalScope.amplitudeGTM._iq || {});
Comment thread
Mercy811 marked this conversation as resolved.
Outdated
for (let i = 0; i < instanceNames.length; i++) {
const instanceName = instanceNames[i];
const instance = Object.assign(GlobalScope.amplitudeGTM._iq[instanceName], createNamedInstance(instanceName));
Expand Down
2 changes: 1 addition & 1 deletion packages/analytics-browser/src/snippet-index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ function resolveCurrentScriptUrl(): string | undefined {
GlobalScope.amplitude._q = [];
runQueuedFunctions(amplitude, queue);

const instanceNames = Object.keys(GlobalScope.amplitude._iq) || [];
const instanceNames = Object.keys(GlobalScope.amplitude._iq || {});
for (let i = 0; i < instanceNames.length; i++) {
const instanceName = instanceNames[i];
const instance = Object.assign(GlobalScope.amplitude._iq[instanceName], createNamedInstance(instanceName));
Expand Down
3 changes: 3 additions & 0 deletions packages/analytics-browser/src/utils/snippet-helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ export const runQueuedFunctions = (instance: object, queue: QueueProxy) => {
* Used to convert proxied Identify and Revenue objects.
*/
export const convertProxyObjectToRealObject = <T>(instance: T, queue: QueueProxy): T => {
if (!queue) {
return instance;
}
Comment thread
Mercy811 marked this conversation as resolved.
Outdated
for (let i = 0; i < queue.length; i++) {
const { name, args, resolve } = queue[i];
const fn = instance && instance[name as keyof T];
Expand Down
11 changes: 11 additions & 0 deletions packages/analytics-browser/test/utils/snippet-helper.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,5 +47,16 @@ describe('snippet-helper', () => {
expect(SnippetHelper.convertProxyObjectToRealObject(instance, queue)).toBe(instance);
expect(resolve).toHaveBeenCalledTimes(1);
});

test('should return instance when queue is undefined', () => {
const instance = { init: jest.fn() };
expect(
SnippetHelper.convertProxyObjectToRealObject(
instance,
undefined as unknown as Parameters<typeof SnippetHelper.convertProxyObjectToRealObject>[1],
),
).toBe(instance);
Comment thread
Mercy811 marked this conversation as resolved.
Outdated
expect(instance.init).not.toHaveBeenCalled();
});
});
});
Loading