Convert design token colors from hex to oklch - #57
Merged
Conversation
Hex can't express lightness/hue relationships or be interpolated without parsing; OKLCH keeps lightness perceptually uniform across hues, which lines up with the build-enforced AAA contrast checks in check-contrast.ts. Values are exact conversions, so rendering is unchanged. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
amyrlam
added a commit
that referenced
this pull request
Jul 24, 2026
Feedback-driven revision: the first draft was long and token-centric. This one covers the site's full story (the geo lookup and "borrowed sky" honesty, real stars, quarter-hour hops, the secret shows, the static-plus-one-function deploy) while cutting overall length ~20%. The tokens shrink to one section, with color-format-agnostic wording plus an oklch mention so the prose survives PR #57's hex-to-oklch conversion. New "objects under the sky" section names the two print mountings (lightbox polaroids vs. the taped dinghy print) as one deliberate family rather than an inconsistency. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@theme(global.css) and the mirrored@propertyinitial-values from hex tooklch(), plus the matching values documented in DESIGN.md's frontmatter and prose.check:contrast) already relies on being true.sky.ts's live sun/moon interpolation in RGB (that's the format it needs for itsmix()math) and left the SVGfill="#0a1030"literal in Layout.astro and the Impeccable-generated.impeccable/design.jsonsnapshot untouched — out of scope for a token-format change.Test plan
pnpm run check:contrast— AAA holds at every sun altitudepnpm run lint:css— clean (stylelint enforcesdegunits on oklch hue, auto-fixed)pnpm run format:check— clean/design-systemswatches render pixel-identical before/after🤖 Generated with Claude Code