Remove get_double_attrs and parse_color; fix color_hex guard#55
Merged
Conversation
andy5995
commented
Jun 17, 2026
andy5995
commented
Owner
- Remove canfigger_get_double_attrs() and canfigger_parse_color() (no concrete consumers; dual-format complexity not justified)
- canfigger_parse_color_hex(): reject strings with non-hex characters via strspn guard (sscanf alone silently mis-parsed e.g. "#12345g")
- Add missing non-hex test cases to tests/color_hex.c
- Remove canfigger_get_double_attrs() and canfigger_parse_color() (no concrete consumers; dual-format complexity not justified) - canfigger_parse_color_hex(): reject strings with non-hex characters via strspn guard (sscanf alone silently mis-parsed e.g. "#12345g") - Add missing non-hex test cases to tests/color_hex.c Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.