docs: correct Test button note - S1/J16 likely same signal, not factory-only#103
Merged
Conversation
…ry-only A closer photo shows S1 (onboard "Test" pushbutton) sits directly adjacent to J16, a 2-pin screw terminal silkscreened "Test btn" - not a 4-pin header as previously written. Retract the earlier "most likely a factory test-jig interface, not a field service feature" read: the adjacency strongly suggests S1 is wired in parallel with J16 as an onboard equivalent of the customer's external green Test button, and the "TEST 464 PASSED" sticker (cited as evidence) is just an unrelated QC-pass label. Firmware only ever found one button-hold flag (DAT_014a), consistent with one logical button. Not proven without a continuity check between S1's pads and J16's terminals. Also fixed: display is 4-digit, not 3-digit. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
S1(onboard "Test" pushbutton) sits directly adjacent toJ16, a 2-pin screw terminal silkscreened "Test btn" — not a 4-pin header as previously written.S1is wired in parallel withJ16as an onboard equivalent of the customer's external green Test button. The "TEST 464 PASSED" sticker (previously cited as supporting evidence) is just an unrelated QC-pass label.DAT_014a), consistent with one logical button rather than two independent inputs.S1's pads andJ16's terminals to confirm same-net.Test plan
docs/ghidra/codes.md's existing firmware trace (single flag, not two)🤖 Generated with Claude Code