Revert nonnull optimizations and remove as casts#53
Open
dilr wants to merge 4 commits intoandylokandy:masterfrom
Open
Revert nonnull optimizations and remove as casts#53dilr wants to merge 4 commits intoandylokandy:masterfrom
dilr wants to merge 4 commits intoandylokandy:masterfrom
Conversation
andylokandy
reviewed
Aug 3, 2025
andylokandy
reviewed
Aug 3, 2025
Author
|
I've mixed back in the changes which make ZSTs allocate on the "heap". This revert came out less clean, but the tests pass under miri. |
Author
|
The previous commit fixes the issue that occurred in CI. It does switch back to an I've also run fmt and a test with the 1.80.0 toolchain, so this commit should pass the CI. |
andylokandy
reviewed
Aug 4, 2025
Co-authored-by: Andy Lok <andylokandy@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #52, this reverts the non-null optimizations. Additionally to keep the CI from complaining this time, I have converted
aspointer casts to use .cast() or .cast_mut(). I can remove this second part if needed.