Skip to content

fix(ci): re-verify PR state before auto-closing to prevent race conditions #5213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fernandolins wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −0
Open

fix(ci): re-verify PR state before auto-closing to prevent race conditions #5213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/auto-close-missing-issue.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,23 @@ jobs:
if (!labelEvent) continue;
if (new Date(labelEvent.created_at) > fourDaysAgo) continue;

// Re-fetch the PR's current state to guard against race conditions:
// the label may have been removed between the initial paginated query
// and this point in the loop.
const currentPr = await github.rest.pulls.get({
owner,
repo,
pull_number: pr.number,
});

if (currentPr.data.state !== 'open') continue;

const currentLabels = currentPr.data.labels.map(l => l.name);
if (!currentLabels.includes('missing-issue')) continue;

const linkedIssuePattern = /\b(closes|close|fixes|fix|resolves|resolve|refs|ref|references)\s+(?:[a-zA-Z0-9_.-]+\/[a-zA-Z0-9_.-]+)?#\d+/i;
if (linkedIssuePattern.test(currentPr.data.body || '')) continue;

await github.rest.pulls.update({
owner,
repo,
Expand Down
Loading