Skip to content

refactor(install): share install entry construction #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
anmonteiro wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

refactor(install): share install entry construction #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions src/dune_rules/install_rules.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,12 +198,13 @@ end = struct

let doc_install_files ~loc mld_contents =
List.rev_map mld_contents ~f:(fun (mld : Doc_sources.mld) ->
Install.Entry.Unexpanded.make
make_entry
None
~kind:Install.Entry.Unexpanded.File
~dst:(sprintf "odoc-pages/%s" (Path.Local.to_string mld.in_doc))
~loc
Section.Doc
mld.path
|> Install.Entry.Sourced.Unexpanded.create ~loc)
mld.path)
;;

let lib_install_files
Expand Down Expand Up @@ -455,11 +456,7 @@ end = struct
and+ execs = lib_ppxs ctx ~scope ~lib
and+ dll_files =
dll_files ~modes:ocaml ~dynlink:lib.dynlink ~ctx info
>>| List.rev_map ~f:(fun a ->
let entry =
Install.Entry.Unexpanded.make ~kind:Install.Entry.Unexpanded.File Stublibs a
in
Install.Entry.Sourced.Unexpanded.create ~loc entry)
>>| List.rev_map ~f:(make_entry ~kind:Install.Entry.Unexpanded.File Stublibs)
in
let install_c_headers =
List.rev_map lib.install_c_headers ~f:(fun (loc, base) ->
Expand Down
Loading