fix(melange): read imported virtual-library dependencies from CMTs - #78
Draft
anmonteiro wants to merge 1 commit into
Draft
fix(melange): read imported virtual-library dependencies from CMTs#78anmonteiro wants to merge 1 commit into
anmonteiro wants to merge 1 commit into
Conversation
This was referenced Aug 21, 2026
anmonteiro
force-pushed
the
anmonteiro/fix-imported-melange-vlib-cmt-deps
branch
from
August 25, 2026 04:19
6f32a11 to
62963d5
Compare
anmonteiro
changed the base branch from
anmonteiro/test-imported-melange-vlib-cmt-deps
to
main
August 25, 2026 04:19
anmonteiro
added a commit
to ocaml/dune
that referenced
this pull request
Aug 25, 2026
Strengthen the installed Melange virtual-library regression test with a private module whose implementation-only dependency is hidden by an interface. Follow-up to #16066; prepares anmonteiro#78. Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
anmonteiro
force-pushed
the
anmonteiro/fix-imported-melange-vlib-cmt-deps
branch
2 times, most recently
from
August 26, 2026 00:21
2a78089 to
070a618
Compare
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
anmonteiro
force-pushed
the
anmonteiro/fix-imported-melange-vlib-cmt-deps
branch
from
August 26, 2026 00:24
070a618 to
c0b25c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read installed Melange virtual-library implementation dependencies from CMTs, including transitive private dependencies.
Follow-up to ocaml#16066. The no-CMT fallback remains in #58.