perf: build qualified group closures with one traversal - #80
Closed
anmonteiro wants to merge 1 commit into
Closed
Conversation
anmonteiro
force-pushed
the
perf/qualified-group-closure
branch
from
August 21, 2026 22:20
55e22a3 to
f096709
Compare
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
anmonteiro
force-pushed
the
perf/qualified-group-closure
branch
from
August 21, 2026 22:44
f096709 to
8fc4492
Compare
Owner
Author
|
Superseded by ocaml#16087. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build qualified-group dependency closures with a reverse accumulator, avoiding intermediate subtree lists and quadratic copying for nested groups.
Local benchmarks show 13.9% lower time for 1,024 flat modules and a 5.2x speedup at nesting depth 128. The benchmark harness is not included.
Independent of ocaml#15752, which batches dependency lookup.