Skip to content

fix: Fix the infinite loop caused by equalizeSegments in special cases #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hustcc merged 4 commits into from
Jul 1, 2025
Merged

fix: Fix the infinite loop caused by equalizeSegments in special cases #129

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
375a0d2
fix: Fix the infinite loop caused by equalizeSegments in special cases
lxfu1 Jul 1, 2025
7a70a03
fix: code style
lxfu1 Jul 1, 2025
55db19a
ci: add tests
lxfu1 Jul 1, 2025
8005850
chore: update version
lxfu1 Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 25 additions & 19 deletions src/path/util/equalize-segments.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import { segmentCubicFactory } from './segment-cubic-factory';

type SplitArray = [number, number, number, number, number, number, number, number, number];

const MAX_RECURSION_DEPTH = 50;

function splitCubic(pts: SplitArray, t = 0.5): [CurveArray, CurveArray] {
const p0 = pts.slice(0, 2) as [number, number];
const p1 = pts.slice(2, 4) as [number, number];
Expand Down Expand Up @@ -32,17 +34,17 @@ function getCurveArray(segments: PathArray) {
// @ts-ignore
const curveLength = i
? segmentCubicFactory(
segmentData[0],
segmentData[1],
segmentData[2],
segmentData[3],
segmentData[4],
segmentData[5],
segmentData[6],
segmentData[7],
segmentData[8],
{ bbox: false },
).length
segmentData[0],
segmentData[1],
segmentData[2],
segmentData[3],
segmentData[4],
segmentData[5],
segmentData[6],
segmentData[7],
segmentData[8],
{ bbox: false },
).length
: 0;

let subsegs;
Expand All @@ -61,7 +63,11 @@ function getCurveArray(segments: PathArray) {
});
}

export function equalizeSegments(path1: PathArray, path2: PathArray, TL?: number): CurveArray[] {
export function equalizeSegments(path1: PathArray, path2: PathArray, TL?: number, depth = 0): CurveArray[] {
if (depth > MAX_RECURSION_DEPTH) {
console.warn('Maximum recursion depth reached in equalizeSegments');
return [path1, path2] as CurveArray[];
}
const c1 = getCurveArray(path1);
const c2 = getCurveArray(path2);
const L1 = c1.length;
Expand All @@ -79,13 +85,13 @@ export function equalizeSegments(path1: PathArray, path2: PathArray, TL?: number
x.l === tl
? x.map((y) => y.s)
: x
.map((y, j) => {
canSplit = j && dif[i] && y.l >= mm[i];
dif[i] -= canSplit ? 1 : 0;
return canSplit ? y.ss : [y.s];
})
.flat(),
.map((y, j) => {
canSplit = j && dif[i] && y.l >= mm[i];
dif[i] -= canSplit ? 1 : 0;
return canSplit ? y.ss : [y.s];
})
.flat(),
) as CurveArray[];

return result[0].length === result[1].length ? result : equalizeSegments(result[0], result[1], tl);
return result[0].length === result[1].length ? result : equalizeSegments(result[0], result[1], tl, depth + 1);
}
Loading