Deterministically box cyclic cddl-derive struct references#562
Draft
Copilot wants to merge 3 commits into
Draft
Conversation
Copilot
AI
changed the title
[WIP] Fix infinite size issue in cddl-derive for recursive types
Deterministically box cyclic May 21, 2026
cddl-derive struct references
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cddl-derivegenerated direct struct-to-struct references for cyclic CDDL rules, which produces infinite-size Rust types (e.g.Node↔Child). This change introduces deterministic cycle breaking by boxing recursive edges during code generation.Recursive type graph analysis
Deterministic cycle breaking
Codegen output updates
RustField(is_boxed).Box<T>/Option<Box<T>>for marked recursive fields while preserving existing optional/serde behavior.Regression coverage
node/child)nodecontainingnode)Now generates finite Rust types (deterministically), e.g.: