Store and present Publish Config from publish node - #108
Open
monoxane wants to merge 4 commits into
Open
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
monoxane
changed the title
Author
|
I have read the CLA Document and I hereby sign the CLA |
|
Just finished setting up a self-hosted any-sync network on Oracle Cloud A1 (ARM64) and this PR is exactly what's blocking the last piece. Currently the only way to point the desktop app at a custom publish server is via env vars at launch — workable on Mac, but completely impossible on iOS. Once this lands and clients can discover the publish server config from the coordinator, it would unlock iOS publishing for self-hosted networks too (assuming anytype-ios implements the Would love to see this merged. Happy to test on self-hosted ARM64 if that helps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds functionality to read network-wide publishing limits and domain configuration from this publish-server's config file, and exposes this information to clients with a
(*publishclient.Client)GetPublishConfigdRPC handler.This functionality improves the security of publishing within an Anytype network as it will allow clients to rely on a central source of truth for this configuration instead of hard-coding it in each client.
This functionality is also required to effectively implement publishing in a self-hosted network as per #107
What type of PR is this? (check all applicable)
Related Tickets & Documents
This PR is a component of Self Hosted Publish Improvements
Added tests?
Added to documentation?
Documentation will be added to tech-docs once the feature is complete across all aspects of the ecosystem