fix(template): per-template depset recipe for the automated Ray bump#831
Merged
Conversation
Aydin-ab
force-pushed
the
fix-ray-bump-depsets
branch
from
4ee81f3 to
6ce3044
Compare
bump-ray-version.md gains a per-template depset recipe (no-lock vs has-lock incremental repoint), a batch-vs-per-template preamble, check-depsets literacy, and explicit Done criteria (never leave a draft with no test dispatched). upgrade-dependencies.md is labeled the human/whole-repo batch path; dependencies.md documents the repo-global gate's collateral behavior. .cursor/preflight.sh smoke-tests the depset toolchain so it fails at preflight, not mid-bump. CI-gate changes (scope-to-changed + retry) and the scheduled refresh live in their own PRs. Claude-Session: https://claude.ai/code/session_01HEiVRurDkXnrLAyCduiLdH Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Aydin-ab
force-pushed
the
fix-ray-bump-depsets
branch
from
6ce3044 to
1b57a58
Compare
This was referenced Jul 1, 2026
…'s deps Expand references/dependencies.md: add a "Running it" section (linux-x86_64 only; macOS via Docker + uname shim) and a "Changing a template's dependencies" recipe; sharpen the base-lock overview (it's Ray's img lock re-emitted minus ray, not a fresh resolve); surface the driver-vs-workers wiring (workers get deps only via runtime_env). Trim redundancy — consolidate the two check-depsets gotchas, drop the parked scoped/scheduled claim, merge the pin traps. Cross-link "Running it" from both workflows. Claude-Session: https://claude.ai/code/session_01HEiVRurDkXnrLAyCduiLdH Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Aydin-ab
force-pushed
the
fix-ray-bump-depsets
branch
from
d0ce34b to
75466d6
Compare
…late only) bump-ray-version.md is the per-template flow; it doesn't need to explain the whole-repo batch alternative. Remove its "Batch vs per-template" preamble and the matching "Audience — whole repo" paragraph in upgrade-dependencies.md. The per-template recipe (add/attach/repoint own entry) already stands on its own. Claude-Session: https://claude.ai/code/session_01HEiVRurDkXnrLAyCduiLdH Signed-off-by: Aydin Abiar <aydin@anyscale.com>
elliot-barn
approved these changes
Jul 2, 2026
…ld shipped) raydepsets v0.0.1 now publishes raydepsets-darwin-arm64 alongside linux-x86_64, so ./update_deps.sh runs natively on both. Drop the Docker + uname-shim workaround from dependencies.md "Running it" and the linux-only caveats in the two workflows. Verified: a native macOS compile of ray_depset_2.56.0_3.11 reproduces the committed lock byte-for-byte. Claude-Session: https://claude.ai/code/session_01HEiVRurDkXnrLAyCduiLdH Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Aydin-ab
force-pushed
the
fix-ray-bump-depsets
branch
2 times, most recently
from
05cc204 to
190e784
Compare
…s disabled) Remove the "## CI gate" section and the "the CI gate" attribution on --check; the gate is disabled, so it's no longer referenced. Reframe the live-index gotcha as a property of update_deps.sh itself (a fresh run can show ambient drift / a transient 503), not of the gate. Claude-Session: https://claude.ai/code/session_01HEiVRurDkXnrLAyCduiLdH Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Stop referring to check-depsets as an active gate across the agent docs: drop the "check-depsets gate" attributions on ./update_deps.sh --check in create-template.md, update-template.md, and upgrade-dependencies.md (kept as local validation), and remove "gated by check-depsets in CI" from AGENTS.md. The only remaining reference is the disabled job itself in premerge.yaml. Claude-Session: https://claude.ai/code/session_01HEiVRurDkXnrLAyCduiLdH Signed-off-by: Aydin Abiar <aydin@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
/templateRay-bump automation had no per-template depset recipe, so the Ray 2.56.0 batch behaved inconsistently. This teaches the skill (and the cursor preflight) how depsets interact with a bump. Docs + preflight only — no CI or lockfile changes (those are #834 / #835 / #833).Why
bump-ray-version.mdonly pointed at the whole-repo batchupgrade-dependencies.md; nothing covered no-lock templates or how to read the repo-globalcheck-depsetsgate./test-template..cursorwas never the block —raydepsetsbundlesuvand recompiled fine in the cursor env; but preflight never smoke-tested the toolchain, so a real breakage would only surface mid-bump.Changes
bump-ray-version.md— per-template depset recipe (no-lock vs has-lock), batch-vs-per-template preamble,check-depsets-is-repo-global note, explicit Done criteria.upgrade-dependencies.md/dependencies.md— label the human/batch path; document the gate's collateral behavior..cursor/preflight.sh— depset-toolchain smoke test (fail at preflight, not mid-bump).Testing
pre-commiton changed files passed. Docs/preflight only — no runtime impact; validated end-to-end by retriggeringtemplate-updateragainst the fixed skill.