fix(java/driver/jni): release AdbcError in RaiseAdbcException#4391
Open
lidavidm wants to merge 2 commits into
Open
fix(java/driver/jni): release AdbcError in RaiseAdbcException#4391lidavidm wants to merge 2 commits into
lidavidm wants to merge 2 commits into
Conversation
We were simply leaking any errors before. Assisted-by: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Fixes a native-memory leak in the Java JNI driver by ensuring AdbcError resources are released when raising Java-side exceptions from failed ADBC calls.
Changes:
- Introduces an
AdbcErrorGuardRAII helper to automatically releaseAdbcErrorresources. - Updates
RaiseAdbcExceptionto take a mutableAdbcError&and invokeerror.release()before throwing. - Replaces many per-function
AdbcErrorstack variables with a sharedAdbcErrorGuardinstance.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were simply leaking any errors before.