test(arrow-select): additional tests for inline-view filter fast path (tests for #9755)#10054
Open
alamb wants to merge 1 commit into
Open
test(arrow-select): additional tests for inline-view filter fast path (tests for #9755)#10054alamb wants to merge 1 commit into
alamb wants to merge 1 commit into
Conversation
alamb
force-pushed
the
alamb/coalesce-fused-filter-tests
branch
from
682b7af to
1c94743
Compare
alamb
force-pushed
the
alamb/coalesce-fused-filter-tests
branch
from
1c94743 to
2b713fb
Compare
alamb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
BatchCoalescer::push_batch_with_filterfor low selectivity filters and inlined Utf8View/BinaryView #9755Rationale for this change
While reviewing #9755 I found, via
cargo llvm-cov, there are some uncovered code paths (for very sparse filters as well as for outputting intermediate blocks)What changes are included in this PR?
target_batch_sizeforcing a flushAre there any user-facing changes?
No. This is test only