Skip to content

Fix serial warning in starter and example archetypes #38028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Subramanya-Veeregowda wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix serial warning in starter and example archetypes #38028

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
60c8a23
Improve the Javadoc for encode/decode methods in coder methods in cod…
Subramanya-Veeregowda Mar 30, 2026
7609051
Apply spotless formatting
Subramanya-Veeregowda Mar 30, 2026
18395a2
Fix minimal javadoc wording for coder encode decode
Subramanya-Veeregowda Mar 31, 2026
88ebf83
Fix serial warning in starter and example archetype
Subramanya-Veeregowda Apr 1, 2026
7502e64
Address review: use @Element and fix formatting revised
Subramanya-Veeregowda Apr 1, 2026
b90cfb5
added import for the starterpipeline
Subramanya-Veeregowda Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions ...hetypes/starter/src/main/resources/archetype-resources/src/main/java/StarterPipeline.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import org.apache.beam.sdk.transforms.SimpleFunction;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.apache.beam.sdk.transforms.DoFn.Element;

/**
* A starter example for writing Beam programs.
Expand All @@ -51,16 +52,20 @@ public static void main(String[] args) {
PipelineOptionsFactory.fromArgs(args).withValidation().create());

p.apply(Create.of("Hello", "World"))
.apply(MapElements.via(new SimpleFunction<String, String>() {
@Override
public String apply(String input) {
return input.toUpperCase();
}
}))
.apply(ParDo.of(new DoFn<String, Void>() {
.apply(
MapElements.via(
new SimpleFunction<String, String>() {
@Override
public String apply(String input) {
return input.toUpperCase();
}
}))
.apply(
ParDo.of(
new DoFn<String, Void>() {
@ProcessElement
public void processElement(ProcessContext c) {
LOG.info(c.element());
public void processElement(@Element String element) {
Copy link
Copy Markdown
Contributor

@stankiewicz stankiewicz Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are missing import:
import org.apache.beam.sdk.transforms.DoFn.Element;

Copy link
Copy Markdown
Contributor Author

@Subramanya-Veeregowda Subramanya-Veeregowda Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! i was in a hurry, update coming soon!. 😁

Copy link
Copy Markdown
Contributor Author

@Subramanya-Veeregowda Subramanya-Veeregowda Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stankiewicz checks passed after updating the request

Copy link
Copy Markdown
Contributor

@stankiewicz stankiewicz Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, I'm wrong, sorry. There is already org.apache.beam.sdk.transforms.DoFn and this is enough.

LOG.info(element);
}
}));

Expand Down
Loading