SPARKC-504: Save null UDTs - #1228
Conversation
|
Hi @acustiq, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign Spark Cassandra Connector CLA. It's all electronic and will take just minutes. |
|
Thank you @acustiq for signing the Spark Cassandra Connector CLA. |
Fix the hyperlink to save modes in the latest Spark documentation
|
Sorry, I really messed up the master branch so a rebase will be necessary. If you could please rebase on b3.0 and I will review as soon as possible. |
…connector into SPARKC-504 rebase
| columnValues(i) = converters(i).convert(columnValues(i)) | ||
| struct.newInstance(columnValues: _*) | ||
| case None => | ||
| case _ => |
There was a problem hiding this comment.
Maybe i'm just paranoid, but should we do None | null? I may just be paranoid (this wouldn't be the first time...)
There was a problem hiding this comment.
I would think that the _ wildcard symbol catches both None and null as it matches anything:
case _ => // Wild card pattern -- matches anything
Source: https://docs.scala-lang.org/tutorials/FAQ/finding-symbols.html
|
All tests pass! Thanks so much for your pr, please let me know you response to my above comment. I'll change the target of this pr to b3.0 to make sure it gets in the next release. |
|
Ah we have a few of the master commits (just docs) got dragged in, could you please rebase on b3.0? |
|
@RussellSpitzer please close this PR in favor of #1241 which has this change rebased on b3.0 . |
4 participants
No description provided.