fix: propagate nested cast errors#4675
Open
manuzhang wants to merge 2 commits into
Open
Conversation
Return nested struct cast failures through DataFusion errors instead of unwrapping arrays during struct-to-struct casts. Add coverage for nested struct, array, and ANSI overflow cases. Co-authored-by: Codex <codex@openai.com>
manuzhang
force-pushed
the
codex/propagate-nested-cast-errors
branch
from
e2f89dd to
9e8d1ca
Compare
comphead
reviewed
Jun 18, 2026
comphead
left a comment
comphead
left a comment
Contributor
There was a problem hiding this comment.
Thanks @manuzhang can we add a sql test as well?
Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4248
Rationale for this change
Nested struct casts currently unwrap nested cast results while building the output
StructArray. When a nested cast fails, such as an ANSI overflow inside a struct, that unwrap can panic instead of returning the cast failure as a normal DataFusion error.What changes are included in this PR?
DataFusionResultinstead of unwrapping.How are these changes tested?
Updated tests suites and added native UTs.
Co-authored-by: @codex